Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc examples for iter flatten #78776

Closed
wants to merge 1 commit into from
Closed

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Nov 5, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2020
@GuillaumeGomez
Copy link
Member

Thanks!

r=me once CI pass

@pickfire
Copy link
Contributor Author

pickfire commented Nov 6, 2020

Ah, I just realized we should hide the imports.

@pickfire
Copy link
Contributor Author

pickfire commented Nov 6, 2020

I just realized we don't have this for the rest of iterators docs, we may need to standardize, most of the docs looks the same but some look different, this one look different too.

@bors
Copy link
Contributor

bors commented Nov 8, 2020

☔ The latest upstream changes (presumably #78874) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@pickfire
Copy link
Contributor Author

pickfire commented Nov 8, 2020

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

I want to know what the docs team before proceeding.

@JohnCSimon
Copy link
Member

Ping from triage @pickfire can you please address the merge conflict?

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2020
@pickfire
Copy link
Contributor Author

@JohnCSimon I am not sure if this pull request is good given that the other parts needed to be changed later when this is merged, I wonder if @GuillaumeGomez think this is good.

@GuillaumeGomez
Copy link
Member

Well, still think the collect and type annotation are too much.

@pickfire
Copy link
Contributor Author

True, even though I think it is easier for beginners but it makes it weird to have some parts have this by itself. Closing it.

@pickfire pickfire closed this Nov 24, 2020
@pickfire pickfire deleted the patch-4 branch November 24, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants