Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stabilize deque_range #79022

Merged
merged 1 commit into from
Dec 26, 2020
Merged

stabilize deque_range #79022

merged 1 commit into from
Dec 26, 2020

Conversation

SpyrosRoum
Copy link
Contributor

Make #74217 stable, stabilizing VecDeque::range and VecDeque::range_mut.
Pr: #74099

r? @m-ou-se

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2020
@m-ou-se m-ou-se added A-collections Area: std::collections. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 13, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 13, 2020

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Nov 13, 2020 •
edited by sfackler
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 13, 2020
@bors
Copy link
Contributor

bors commented Nov 15, 2020

☔ The latest upstream changes (presumably #79065) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@m-ou-se
Copy link
Member

m-ou-se commented Nov 15, 2020 •
edited
Loading

@SpyrosRoum Looks like you accidentally pulled in changes a few unrelated commits into this PR while addressing the merge conflict. Try rebasing: git remote update; git rebase origin/master. ^^

@SpyrosRoum
Copy link
Contributor Author

I think I didn't do the correct thing. Sorry I'm not that familiar with git and actually working with other people 😅

@m-ou-se m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2020
@Dylan-DPC-zz
Copy link

@Amanieu @KodrAus @sfackler @withoutboats this is waiting on your vote/concerns

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 9, 2020
@rfcbot
Copy link

rfcbot commented Dec 9, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 19, 2020
@rfcbot
Copy link

rfcbot commented Dec 19, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@m-ou-se
Copy link
Member

m-ou-se commented Dec 24, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 24, 2020

📌 Commit 161300d has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 24, 2020
@bors
Copy link
Contributor

bors commented Dec 26, 2020

⌛ Testing commit 161300d with merge d30dac2...

@alex
Copy link
Member

alex commented Dec 26, 2020

This has since=1.50.0, but the PR to change master to 1.51.0 has already landed. I think this needs to be removed from teh queue and fixed for that (unless there's a plan to cherry-pick to beta).

@bors
Copy link
Contributor

bors commented Dec 26, 2020

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing d30dac2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2020
@bors bors merged commit d30dac2 into rust-lang:master Dec 26, 2020
@rustbot rustbot added this to the 1.51.0 milestone Dec 26, 2020
@m-ou-se m-ou-se mentioned this pull request Dec 28, 2020
Merged
@m-ou-se
Copy link
Member

m-ou-se commented Dec 28, 2020

@alex Thanks! Fixed in #80448.

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Dec 28, 2020
@m-ou-se
Rollup merge of rust-lang#80448 - m-ou-se:deque-range-version, r=m-ou-se
e3d26e0 
Fix stabilization version of deque_range feature.

See rust-lang#79022 (comment)
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Dec 31, 2020
@pthariensflame
Copy link
Contributor

This needs relnotes. (Or should #80448 have it instead?)

@CDirkx CDirkx mentioned this pull request Mar 24, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 24, 2021
@Dylan-DPC
Rollup merge of rust-lang#83438 - CDirkx:releases, r=Mark-Simulacrum
26004b3 
Update RELEASES.md

A couple of things that were missing in the release notes:

- `Div` and `Rem` by their `NonZero` variant is now implemented for all unsigned integers (rust-lang#79134)
- Stabilization of `VecDeque::range` and `VecDeque::range_mut` (rust-lang#79022, stabilization version corrected to 1.51.0 rust-lang#80448)
- Deprecation of `spin_loop_hint` (rust-lang#80966)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 12, 2021
@Dylan-DPC
Rollup merge of rust-lang#83438 - CDirkx:releases, r=Mark-Simulacrum
968893f 
Update RELEASES.md

A couple of things that were missing in the release notes:

- `Div` and `Rem` by their `NonZero` variant is now implemented for all unsigned integers (rust-lang#79134)
- Stabilization of `VecDeque::range` and `VecDeque::range_mut` (rust-lang#79022, stabilization version corrected to 1.51.0 rust-lang#80448)
- Deprecation of `spin_loop_hint` (rust-lang#80966)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 13, 2021
@Dylan-DPC
Rollup merge of rust-lang#83438 - CDirkx:releases, r=Mark-Simulacrum
9191dee 
Update RELEASES.md

A couple of things that were missing in the release notes:

- `Div` and `Rem` by their `NonZero` variant is now implemented for all unsigned integers (rust-lang#79134)
- Stabilization of `VecDeque::range` and `VecDeque::range_mut` (rust-lang#79022, stabilization version corrected to 1.51.0 rust-lang#80448)
- Deprecation of `spin_loop_hint` (rust-lang#80966)
@dtolnay dtolnay mentioned this pull request Dec 22, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
A-collections Area: std::collections. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
10 participants
@SpyrosRoum @rust-highfive @m-ou-se @rfcbot @bors @Dylan-DPC-zz @alex @pthariensflame @spastorino @rustbot