Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error to reflect that integer literals can have float suffixes #79329

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Update error to reflect that integer literals can have float suffixes #79329

merged 1 commit into from
Nov 30, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Nov 23, 2020

For example, 1 is parsed as an integer literal, but it can be turned
into a float with the suffix f32. Now the error calls them "numeric
literals" and notes that you can add a float suffix since they can be
either integers or floats.

@camelid camelid added A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST. labels Nov 23, 2020
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2020
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2020

📌 Commit b11d0f2 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2020
@bors
Copy link
Contributor

bors commented Nov 25, 2020

⌛ Testing commit b11d0f2 with merge b02208a1d22fdfc560acda765e50c9ee5b90cac5...

@bors
Copy link
Contributor

bors commented Nov 26, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 26, 2020
@jonas-schievink
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2020
@camelid
Copy link
Member Author

camelid commented Nov 26, 2020

Why have there been so many spurious bors failures?

@jonas-schievink jonas-schievink mentioned this pull request Nov 26, 2020
Closed
@jonas-schievink
Copy link
Contributor

@bors r- failed in #79440

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 26, 2020
@camelid
Copy link
Member Author

camelid commented Nov 26, 2020

Looks like I need to update clippy tests :/

@camelid
Update error to reflect that integer literals can have float suffixes
a3cde63 
For example, `1` is parsed as an integer literal, but it can be turned
into a float with the suffix `f32`. Now the error calls them "numeric
literals" and notes that you can add a float suffix since they can be
either integers or floats.
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2020
@camelid
Copy link
Member Author

camelid commented Nov 28, 2020

Okay, should be ready for another r+ now!

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 29, 2020

📌 Commit a3cde63 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2020
@bors
Copy link
Contributor

bors commented Nov 30, 2020

⌛ Testing commit a3cde63 with merge 28b86e0...

@bors
Copy link
Contributor

bors commented Nov 30, 2020

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 28b86e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2020
@bors bors merged commit 28b86e0 into rust-lang:master Nov 30, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 30, 2020
@camelid camelid deleted the int-lit-suffix-error branch November 30, 2020 04:16
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 6, 2020
@bors
Auto merge of rust-lang#79329 - camelid:int-lit-suffix-error, r=david…
3be53bc 
…twco

Update error to reflect that integer literals can have float suffixes

For example, `1` is parsed as an integer literal, but it can be turned
into a float with the suffix `f32`. Now the error calls them "numeric
literals" and notes that you can add a float suffix since they can be
either integers or floats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camelid @rust-highfive @davidtwco @bors @jonas-schievink @rustbot