Remove unnecessary after_run function
#81184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
C-cleanup
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
It's called at the same time and in the same place as `after_krate`, so they can be combined.
|
r? @CraftSpider |
pickfire
approved these changes
Jan 19, 2021
pickfire
reviewed
Jan 19, 2021
| /// Called after everything else to write out errors. | ||
| fn after_run(&mut self, diag: &rustc_errors::Handler) -> Result<(), Error>; | ||
| /// | ||
| /// A handler is available if the renderer wants to report errors. |
There was a problem hiding this comment.
I think this should mention when will the handler be called to report errors. In this case it should be after post processing.
There was a problem hiding this comment.
That is not guarenteed by this trait, that's an implementation detail of html::render::Context. So I don't think it should be documented.
CraftSpider
approved these changes
Jan 19, 2021
|
Thanks! @bors r=CraftSpider rollup |
|
📌 Commit d926147 has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 20, 2021
Remove unnecessary `after_run` function It's called at the same time and in the same place as `after_krate`, so they can be combined.
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 20, 2021
Remove unnecessary `after_run` function It's called at the same time and in the same place as `after_krate`, so they can be combined.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 21, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#79655 (Add Vec visualization to understand capacity) - rust-lang#80172 (Use consistent punctuation for 'Prelude contents' docs) - rust-lang#80429 (Add regression test for mutual recursion in obligation forest) - rust-lang#80601 (Improve grammar in documentation of format strings) - rust-lang#81046 (Improve unknown external crate error) - rust-lang#81178 (Visit only terminators when removing landing pads) - rust-lang#81179 (Fix broken links with `--document-private-items` in the standard library) - rust-lang#81184 (Remove unnecessary `after_run` function) - rust-lang#81185 (Fix ICE in mir when evaluating SizeOf on unsized type) - rust-lang#81187 (Fix typo in counters.rs) - rust-lang#81219 (Document security implications of std::env::temp_dir) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's called at the same time and in the same place as
after_krate, sothey can be combined.