Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand: Refactor module loading #82415

Merged
merged 9 commits into from
Mar 8, 2021
Merged

expand: Refactor module loading #82415

merged 9 commits into from
Mar 8, 2021

Commits on Mar 4, 2021

  1. expand: Remove obsolete DirectoryOwnership::UnownedViaMod 

    This ownership kind is only constructed in the case of path attributes like `#[path = ".."]` without a file name segment, which always represent some kind of directories and will produce and error on attempt to parse them as a module file.
    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    bc18eb4 View commit details
    Browse the repository at this point in the history

  2. expand: Move module file path stack from global session to expansion … 

    …data

Also don't push the paths on the stack directly in `fn parse_external_mod`, return them instead.
    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    39052c5 View commit details
    Browse the repository at this point in the history

  3. expand: Determine module directory path directly instead of relying o… 

    …n span
    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    5bdf81d View commit details
    Browse the repository at this point in the history

  4. expand: Less path cloning during module loading

    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    3d0b622 View commit details
    Browse the repository at this point in the history

  5. expand: Some more consistent naming in module loading

    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    46b67aa View commit details
    Browse the repository at this point in the history

  6. rustc_interface: Hide some hacky details of early linting from expand

    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    da3419e View commit details
    Browse the repository at this point in the history

  7. expand: Align some code with the PR fixing inner attributes on out-of… 

    …-line modules
    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    29a9ef2 View commit details
    Browse the repository at this point in the history

  8. expand: Share some code between inline and out-of-line module treatment

    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    1e1d574 View commit details
    Browse the repository at this point in the history

  9. expand: Introduce enum for module loading errors and make module load… 

    …ing speculative
    @petrochenkov
    petrochenkov committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    1fe2eb8 View commit details
    Browse the repository at this point in the history