Add a min_type_alias_impl_trait feature gate
#82898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jackh726
added
the
WG-traits
|
☔ The latest upstream changes (presumably #82982) made this pull request unmergeable. Please resolve the merge conflicts. |
8 tasks
oli-obk
force-pushed
the
tait_
branch
2 times, most recently
from
e08e1dc
to
9a36840
Compare
This comment has been minimized.
This comment has been minimized.
nikomatsakis
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
This PR...seems pretty clean, @oli-obk! Left one suggestion. r=me with the comments.
|
@bors r=nikomatsakis |
|
📌 Commit 5d112657219d6b9543793f61d4f649b8dde5829a has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r=nikomatsakis |
|
📌 Commit 4bc1434 has been approved by |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
Add a `min_type_alias_impl_trait` feature gate This new feature gate only permits type alias impl trait to be constrained by function and trait method return types. All other possible constraining sites like const/static types, closure return types and binding types are now forbidden and gated under the `type_alias_impl_trait` and `impl_trait_in_bindings` feature gates (which are both marked as incomplete, as they have various ways to ICE the compiler or cause query cycles where they shouldn't). r? `@nikomatsakis` This is best reviewed commit-by-commit
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 15, 2021
Add a `min_type_alias_impl_trait` feature gate This new feature gate only permits type alias impl trait to be constrained by function and trait method return types. All other possible constraining sites like const/static types, closure return types and binding types are now forbidden and gated under the `type_alias_impl_trait` and `impl_trait_in_bindings` feature gates (which are both marked as incomplete, as they have various ways to ICE the compiler or cause query cycles where they shouldn't). r? ``@nikomatsakis`` This is best reviewed commit-by-commit
|
⌛ Testing commit 4bc1434 with merge 1048ced8e57e19caa9b1ad54134043686f19b12c... |
bors
added
S-waiting-on-author
|
@bors r=nikomatsakis rollup=iffy |
|
📌 Commit c2683aa has been approved by |
|
@bors rollup=never could theoretically affect perf |
|
⌛ Testing commit c2683aa with merge 998cb3882f027433e1f5b17da3302abe8a78477e... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors r=nikomatsakis |
|
📌 Commit e675941 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature gate only permits type alias impl trait to be constrained by function and trait method return types. All other possible constraining sites like const/static types, closure return types and binding types are now forbidden and gated under the
type_alias_impl_traitandimpl_trait_in_bindingsfeature gates (which are both marked as incomplete, as they have various ways to ICE the compiler or cause query cycles where they shouldn't).r? @nikomatsakis
This is best reviewed commit-by-commit