convert slice doc link to intra-doc links

[mockersf]

Continuing where #80189 stopped, with core::slice.

I had an issue with two dead links in my doc when implementing Deref<Target = [T]> for one of my type. This means that binary_search_by_key was available, but not sort_by_key even though it was linked in it's doc (same issue with as_ptr and as_mut_pbr). It becomes available if I implement DerefMut, as it needs an &mut self.

Code that will have dead links in its doc

pub struct A;
pub struct B;

impl std::ops::Deref for B{
    type Target = [A];

    fn deref(&self) -> &Self::Target {
        &A
    }
}

I removed the link to sort_by_key from binary_search_by_key doc as I didn't find a nice way to have a live link:

• binary_search_by_key is in core
• sort_by_key is in alloc
• intra-doc link slice::sort_by_key doesn't work, as alloc is not available when core is being build (the warning can't be ignored: error[E0710]: an unknown tool name found in scoped lint: `rustdoc::broken_intra_doc_links` )
• keeping the link as an anchor #method.sort_by_key meant a dead link
• an absolute link would work but doesn't feel right...

[rust-highfive]

r? @KodrAus

(rust-highfive has picked a reviewer for you, use r? to override)

[jyn514]

I removed the link to sort_by_key from binary_search_by_key doc as I didn't find a nice way to have a live link:

I would rather not do this. If you can't get the linkchecker to work, you can add an exception:

rust/src/tools/linkchecker/main.rs

Line 35 in 861872b

const LINKCHECK_EXCEPTIONS: &[(&str, &[&str])] = &[

[jyn514]

(the warning can't be ignored: error[E0710]: an unknown tool name found in scoped lint: rustdoc::broken_intra_doc_links )

You could use

#[cfg_attr(bootstrap, allow(broken_intra_doc_links)]
#[cfg_attr(not(bootstrap), allow(rustdoc::broken_intra_doc_links))]

But I'd rather you didn't, it means the links will be broken when looking at https://doc.rust-lang.org/nightly/core/primitive.slice.html#method.sort_by_key.

[jyn514]

This looks great, thanks! Feel free to ping me when the tests pass and I'll approve the PR :)

[mockersf]

@jyn514 tests are done!

[jyn514]

@bors r+ rollup

Thanks for the PR!

[bors]

📌 Commit 232b9f1 has been approved by jyn514