Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize debug_non_exhaustive #83041

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Mar 11, 2021

tracking issue: #67364

but it is still an open question whether the other Debug* struct's should have a similar method. I would guess that would best be put underneath a new feature gate, as this one seems uncontroversial enough to stabilize as is

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2021
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@kennytm
Copy link
Member

kennytm commented Mar 12, 2021

r? @m-ou-se

@rust-highfive rust-highfive assigned m-ou-se and unassigned kennytm Mar 12, 2021
@kennytm kennytm added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Mar 12, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Mar 13, 2021

I've started the FCP process on the tracking issue: #67364 (comment)

Marking this as blocked.

@m-ou-se m-ou-se added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Mar 24, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 24, 2021

📌 Commit b1fac3a has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Mar 24, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83041 (stabilize debug_non_exhaustive)
 - rust-lang#83349 (Remove Option::{unwrap_none, expect_none}.)
 - rust-lang#83420 (Add documentation for rustdoc-gui tests)
 - rust-lang#83421 (Add Result::into_err where the Ok variant is the never type)
 - rust-lang#83427 (small cleanups in rustc_errors / emitter)
 - rust-lang#83434 (Update RELEASES.md)
 - rust-lang#83440 (Use intra-doc link in core::cell)
 - rust-lang#83442 (LLVMWrapper: attractive nuisance macros)

Failed merges:

 - rust-lang#83438 (Update RELEASES.md)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a6ababb into rust-lang:master Mar 25, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 25, 2021
@pthariensflame
Copy link
Contributor

relnotes?

@m-ou-se m-ou-se added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 25, 2021
@derekdreery
Copy link
Contributor

Do you want me to do some release notes? Do I just add them to RELEASES.md?

@pthariensflame
Copy link
Contributor

@derekdreery IIRC you shouldn’t have to do anything; the relnotes flag will be picked up by the people authoring RELEASES.md when that time comes.

@guswynn guswynn deleted the stable_debug_struct branch September 26, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants