Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give full path of constraint in suggest_constraining_type_param #83673

Merged
merged 1 commit into from
Apr 2, 2021
Merged

give full path of constraint in suggest_constraining_type_param #83673

merged 1 commit into from
Apr 2, 2021

Conversation

Rustin170506
Copy link
Member

close #83513

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2021
@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2021

r? @estebank

feeling unsure about whether using full paths is actually desirable, but don't have a strong opinion here

@rust-highfive rust-highfive assigned estebank and unassigned lcnr Mar 30, 2021
@Rustin170506 Rustin170506 force-pushed the rustin-patch-suggestion branch 2 times, most recently from 6f74059 to 1f3d049 Compare March 30, 2021 11:23
@estebank
Copy link
Contributor

Oh! It's a shame that it also affects things in the prelude 🤔

The current behavior means you get two errors but if you apply both suggestions you get to working code. The new behavior means a single step to working code, at the cost of verbosity.

@lcnr what do you think about this: lets land this (to reduce fix cycles for users) and revisit this output once we have real "locally accessible paths" for these suggestions where we can reduce the verbosity again.

@lcnr
Copy link
Contributor

lcnr commented Mar 30, 2021

what do you think about this: lets land this (to reduce fix cycles for users) and revisit this output once we have real "locally accessible paths" for these suggestions where we can reduce the verbosity again.

👍

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2021

📌 Commit 1f3d049 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 30, 2021
@Dylan-DPC
Rollup merge of rust-lang#83673 - hi-rustin:rustin-patch-suggestion, …
51fa639 
…r=estebank

give full path of constraint in suggest_constraining_type_param

close rust-lang#83513
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 30, 2021
Closed
@Dylan-DPC-zz
Copy link

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2021
@Rustin170506
Copy link
Member Author

failed in rollup

@bors r-

failed in rollup

@bors r-

@Dylan-DPC Blessed with nll compare mode.

@Rustin170506
Copy link
Member Author

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2021
@Dylan-DPC-zz
Copy link

@bors r=estebank

@bors
Copy link
Contributor

bors commented Mar 31, 2021

📌 Commit 8f77356 has been approved by estebank

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 31, 2021
@Dylan-DPC
Rollup merge of rust-lang#83673 - hi-rustin:rustin-patch-suggestion, …
918166e 
…r=estebank

give full path of constraint in suggest_constraining_type_param

close rust-lang#83513
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 31, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 31, 2021
@Dylan-DPC
Rollup merge of rust-lang#83673 - hi-rustin:rustin-patch-suggestion, …
cb59053 
…r=estebank

give full path of constraint in suggest_constraining_type_param

close rust-lang#83513
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 31, 2021
Closed
@Dylan-DPC-zz
Copy link

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2021
@Rustin170506
Copy link
Member Author

failed in rollup

@bors r-

@Dylan-DPC I tested both modes again locally with no problems, so I don't know what's wrong, do you have any suggestions?

image

@Rustin170506
Copy link
Member Author

It seems that without my commit, this #83728 PR is also failing because of the same problem?

@Rustin170506
Copy link
Member Author

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2021
@Dylan-DPC-zz
Copy link

let's give it a try once,

@bors r=estebank

@bors
Copy link
Contributor

bors commented Apr 1, 2021

📌 Commit 8f77356 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2021
@Rustin170506
Copy link
Member Author

let's give it a try once,

Thanks, maybe we can rollup this time without the other PRs that modify the diagnostic information, otherwise it might fail again and we still don't know if the PR is the problem.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 1, 2021
@Dylan-DPC
Rollup merge of rust-lang#83673 - hi-rustin:rustin-patch-suggestion, …
3a7479d 
…r=estebank

give full path of constraint in suggest_constraining_type_param

close rust-lang#83513
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 1, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 2, 2021
@Dylan-DPC
Rollup merge of rust-lang#83673 - hi-rustin:rustin-patch-suggestion, …
0c4b370 
…r=estebank

give full path of constraint in suggest_constraining_type_param

close rust-lang#83513
This was referenced Apr 2, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2021
@bors
Auto merge of rust-lang#83790 - Dylan-DPC:rollup-p6ep8jo, r=Dylan-DPC
138fd56 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#83065 (Rework `std::sys::windows::alloc`)
 - rust-lang#83478 (rustdoc: Add unstable option to only emit shared/crate-specific files)
 - rust-lang#83629 (Fix double-drop in `Vec::from_iter(vec.into_iter())` specialization when items drop during panic)
 - rust-lang#83673 (give full path of constraint in suggest_constraining_type_param)
 - rust-lang#83755 (Simplify coverage tests)
 - rust-lang#83757 (2229: Support migration via rustfix)
 - rust-lang#83771 (Fix stack overflow detection on FreeBSD 11.1+)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6cb74ad into rust-lang:master Apr 2, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 2, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-suggestion branch April 3, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Error message doesn't give full path in suggestion.
8 participants
@Rustin170506 @rust-highfive @lcnr @estebank @bors @Dylan-DPC-zz @rust-log-analyzer @rustbot