Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustc_lint_defs documentation typo #83810

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Fix rustc_lint_defs documentation typo #83810

merged 1 commit into from
Apr 4, 2021

Conversation

benmezger
Copy link
Contributor

@benmezger benmezger commented Apr 3, 2021 •
edited
Loading

Found a typo while reading the documentation. This PR fixes it.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 3, 2021
@jonas-schievink
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 3, 2021

📌 Commit 7b05cff has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021
@jonas-schievink
Copy link
Contributor

@bors rollup

@JohnTitor JohnTitor mentioned this pull request Apr 3, 2021
Merged
@ehuss
Copy link
Contributor

ehuss commented Apr 3, 2021

Sorry, I make that typo way too often (I just did it again this morning). I don't know why my fingers don't want to type that word correctly.

@benmezger
Copy link
Contributor Author

Sorry, I make that typo way too often (I just did it again this morning). I don't know why my fingers don't want to type that word correctly.

Don't worry. I first fixed the typo by repeating the typo 😅

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2021
@bors
Auto merge of rust-lang#83811 - JohnTitor:rollup-hnw1xwz, r=JohnTitor
2616ab1 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#82487 (Constify methods of `std::net::SocketAddr`, `SocketAddrV4` and `SocketAddrV6`)
 - rust-lang#83756 (rustdoc: Rename internal uses of `spotlight`)
 - rust-lang#83780 (Document "standard" conventions for error messages)
 - rust-lang#83787 (Monomorphization doc fix)
 - rust-lang#83803 (add fp-armv8 for ARM_ALLOWED_FEATURES)
 - rust-lang#83804 (Remove nightly features in rustc_type_ir)
 - rust-lang#83810 (Fix rustc_lint_defs documentation typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b2daca7 into rust-lang:master Apr 4, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 4, 2021
@benmezger benmezger deleted the update-builtin-docs-typo branch April 4, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
7 participants
@benmezger @rust-highfive @jonas-schievink @bors @ehuss @varkor @rustbot