Make AssertKind::fmt_assert_args public #84392
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Stumbled over this not being public in viperproject/prusti-dev#467, so i thought i'd go ahead and suggest it be made public. Also open to "you should approach this completely differently"-type suggestions. I know there is a |
|
Sorry for the delay in getting to this. The change seems fine, but there are others who might have opinions on whether there's a better approach, so I'd like to double-check. |
|
I'm not a regular in this piece of code, but this makes sense to me. |
|
📌 Commit b9a1e69 has been approved by |
bors
added
S-waiting-on-bors
…or,RalfJung Make AssertKind::fmt_assert_args public
…or,RalfJung Make AssertKind::fmt_assert_args public
…or,RalfJung Make AssertKind::fmt_assert_args public
Rollup of 5 pull requests Successful merges: - rust-lang#84358 (Update closure capture error logging for disjoint captures for disjoint captures) - rust-lang#84392 (Make AssertKind::fmt_assert_args public) - rust-lang#84752 (Fix debuginfo for generators) - rust-lang#84763 (shrink doctree::Module) - rust-lang#84821 (Fix nit in rustc_session::options) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
See viperproject#467 and rust-lang/rust#84392 for context.
No description provided.