make feature recommendations optional #84705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
const_generics-rec
branch
from
e840b73
to
030e650
Compare
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
const_generics-rec
branch
from
030e650
to
da6261e
Compare
|
Looks good to me. r=me once CI passes. |
|
@bors r+ rollup |
|
📌 Commit da6261e has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
approving your own prs is kinda bad :p @bors r=joshtriplett rollup |
|
📌 Commit da6261e has been approved by |
bors
added
S-waiting-on-bors
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
…lett make feature recommendations optional this is what we're already doing for other feature gates, so it's better to be consistent
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
…lett make feature recommendations optional this is what we're already doing for other feature gates, so it's better to be consistent
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
…lett make feature recommendations optional this is what we're already doing for other feature gates, so it's better to be consistent
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
…lett make feature recommendations optional this is what we're already doing for other feature gates, so it's better to be consistent
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#84451 (Use flex more consistently) - rust-lang#84590 (Point out that behavior might be switched on 2015 and 2018 too one day) - rust-lang#84682 (Don't rebind in `transitive_bounds_that_define_assoc_type`) - rust-lang#84683 (Minor grammar tweaks for readability to btree internals) - rust-lang#84688 (Remove unnecessary CSS rules for search results) - rust-lang#84690 (Remove unneeded bottom margin on search results) - rust-lang#84692 (Link between std::env::{var, var_os} and std::env::{vars, vars_os}) - rust-lang#84705 (make feature recommendations optional) - rust-lang#84706 (Drop alias `reduce` for `fold` - we have a `reduce` function) - rust-lang#84713 (Fix labels for regression issue template) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is what we're already doing for other feature gates, so it's better to be consistent