Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #84840

Merged
merged 15 commits into from
May 3, 2021
Merged

Rollup of 6 pull requests #84840

merged 15 commits into from
May 3, 2021

Commits on Apr 10, 2021

  1. Allow setting target_family to multiple values

    This enables us to set more generic labels shared between targets. For
    example `target_family="wasm"` across all targets that are conceptually
    "wasm".
    
    See rust-lang/reference#1006
    nagisa committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    4afea69 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2021

  1. Configuration menu
    Copy the full SHA
    50c86db View commit details
    Browse the repository at this point in the history

Commits on May 2, 2021

  1. Configuration menu
    Copy the full SHA
    fe540ae View commit details
    Browse the repository at this point in the history
  2. Add ErrorKind::OutOfMemory

    kornelski committed May 2, 2021
    Configuration menu
    Copy the full SHA
    541c8d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    19568f9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5cc21d9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ca6d58 View commit details
    Browse the repository at this point in the history
  6. PR feedback

    scottmcm committed May 2, 2021
    Configuration menu
    Copy the full SHA
    40ffa94 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1a491e2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#84072 - nagisa:target-family-two-the-movie,…

    … r=petrochenkov
    
    Allow setting `target_family` to multiple values, and implement `target_family="wasm"`
    
    As per the conclusion in [this thread](https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Are.20we.20comfortable.20with.20adding.20an.20insta-stable.20cfg.28wasm.29.3F/near/233158441), this implements an ability to specify any number of `target_family` values, allowing for more flexible generic groups, or "families", to be created than just the OS-based unix/windows dichotomy.
    
    cc rust-lang/reference#1006
    Dylan-DPC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    966e9e2 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#84744 - kornelski:enomem, r=joshtriplett

    Add ErrorKind::OutOfMemory
    
    Ability to express `ENOMEM` as an `io::Error`.
    
    I've used `OutOfMemory` as opposed to `NotEnoughMem` or `AllocationFailed`, because "OOM" is used in Rust already.
    
    See also rust-lang#84612
    Dylan-DPC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    77abe7a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#84784 - JulianKnodt:suggest_const, r=lcnr

    Add help message to suggest const for unused type param
    
    r? `@lcnr`
    Dylan-DPC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    0133af5 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#84811 - scottmcm:rustdoc-trait-alias-fix, r…

    …=jyn514
    
    RustDoc: Fix bounds linking trait.Foo instead of traitalias.Foo
    
    Fixes rust-lang#84782
    
    The code was assuming `Trait` when adding bounds to the cache, so add a check on the DefId to see what its kind really is.
    
    r? `@jyn514`
    
    Before:
    ![image](https://user-images.githubusercontent.com/18526288/116775611-6a751e80-aa53-11eb-84d0-ed6b7782be3c.png)
    
    After:
    ![image](https://user-images.githubusercontent.com/18526288/116802227-d19cdc80-ab00-11eb-8133-7b34dd750da2.png)
    Dylan-DPC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    37ce332 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#84818 - ABouttefeux:enum-suggest, r=jackh726

    suggestion for unit enum variant when matched with a patern
    
    resolve rust-lang#84700
    
    add suggestion for code like
    ```rust
    enum FarmAnimal {
        Worm,
        Cow,
        Bull,
        Chicken { num_eggs: usize },
        Dog (String),
    }
    
    fn what_does_the_animal_say(animal: &FarmAnimal) {
    
        let noise = match animal {
            FarmAnimal::Cow(_) => "moo".to_string(),
            _ => todo!()
        };
    
        println!("{:?} says: {:?}", animal, noise);
    }
    ```
    
    ```
    error[E0532]: expected tuple struct or tuple variant, found unit variant `FarmAnimal::Cow`
      --> $DIR/issue-84700.rs:15:9
       |
    LL |     Cow,
       |     --- `FarmAnimal::Cow` defined here
    ...
    LL |         FarmAnimal::Cow(_) => "moo".to_string(),
       |         ^^^^^^^^^^^^^^^^^^ help: use this syntax instead: `FarmAnimal::Cow`
       ```
    Dylan-DPC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    b0c7e64 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#84832 - Stupremee:dont-print-vis-in-externa…

    …l-traits, r=jyn514
    
    Do not print visibility in external traits
    
    This PR fixes the bug that caused traits, which were re-exported, having visibility modifiers in front of methods, which is invalid.
    
    It would be nice to add a test for this, but I don't even know if tests with multiple crates are possible.
    
    Resolves rust-lang#81274
    Dylan-DPC committed May 2, 2021
    Configuration menu
    Copy the full SHA
    83c49d0 View commit details
    Browse the repository at this point in the history