Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --print unversioned-files from rustdoc #85770

Merged
merged 1 commit into from
May 30, 2021

Conversation

Bobo1239
Copy link
Contributor

@Bobo1239 Bobo1239 commented May 28, 2021

This flag isn't needed anymore. See #83784.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2021
@jyn514
Copy link
Member

jyn514 commented May 28, 2021

A better fix is to remove this test and functionality altogether: #83784

@Bobo1239
Copy link
Contributor Author

I can also do that. Just to confirm: The PR on the docs.rs side was merged a month ago so I can just remove everything related to --print=unversioned-files? Or is there another blocker to not do this now?

@jyn514
Copy link
Member

jyn514 commented May 28, 2021

@Bobo1239 yes, you can just remove it completely

@Bobo1239 Bobo1239 changed the title Set LC_ALL=C for sort Remove --print unversioned-files from rustdoc May 28, 2021
@jyn514
Copy link
Member

jyn514 commented May 29, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 29, 2021

📌 Commit 8b6dad2 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2021
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. requires-nightly This issue requires a nightly compiler in some way. labels May 29, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 30, 2021
Remove `--print unversioned-files` from rustdoc

This flag isn't needed anymore. See rust-lang#83784.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 30, 2021
…laumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#85285 (Add eslint checks to CI)
 - rust-lang#85709 (Use correct edition when parsing `:pat` matchers)
 - rust-lang#85762 (Do not try to build LLVM with Zlib on Windows)
 - rust-lang#85770 (Remove `--print unversioned-files` from rustdoc )
 - rust-lang#85781 (Add documentation for aarch64-apple-ios-sim target)
 - rust-lang#85801 (Add `String::extend_from_within`)
 - rust-lang#85817 (Fix a typo)
 - rust-lang#85818 (Don't drop `PResult` without handling the error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7fb29b into rust-lang:master May 30, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. requires-nightly This issue requires a nightly compiler in some way. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants