Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from LocalAnalyzer #85965

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Remove dead code from LocalAnalyzer #85965

merged 2 commits into from
Jun 7, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jun 3, 2021

No description provided.

This code has been dead since changes in 68961.
The else branch is taken when projection slice is empty so everything
except for the call to the `visit_local` is a dead code.
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2021
@nagisa
Copy link
Member

nagisa commented Jun 6, 2021

Nice!

@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2021

📌 Commit 624c693 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 6, 2021
Remove dead code from `LocalAnalyzer`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 7, 2021
…laumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#83433 (Pass --cfg=bootstrap for proc macros built by stage0)
 - rust-lang#84940 (Don't run sanity checks for `x.py setup`)
 - rust-lang#85912 (Use `Iterator::any` and `filter_map` instead of open-coding them)
 - rust-lang#85965 (Remove dead code from `LocalAnalyzer`)
 - rust-lang#86010 (Fix two ICEs in the parser)
 - rust-lang#86040 (Fix display for search results)
 - rust-lang#86058 (Remove `_`  from E0121 diagnostic suggestions)
 - rust-lang#86077 (Fix corrected example in E0759.md)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a3c76f6 into rust-lang:master Jun 7, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 7, 2021
@tmiasko tmiasko deleted the a branch June 7, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants