std: Stabilize wasm simd intrinsics #86204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
7 tasks
jonas-schievink
added
the
relnotes
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnTitor
added
the
T-libs-api
This comment has been minimized.
This comment has been minimized.
|
r? @Amanieu |
|
@bors r+ rollup=never |
|
📌 Commit 858f1610db058f75a53ead9c9d72213fd14c3343 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 858f1610db058f75a53ead9c9d72213fd14c3343 with merge a3221661d8c059c59ef78b87bad2e99b9d00e78b... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This commit performs two changes to stabilize Rust support for WebAssembly simd intrinsics: * The stdarch submodule is updated to pull in rust-lang/stdarch#1179. * The `wasm_target_feature` feature gate requirement for the `simd128` feature has been removed, stabilizing the name `simd128`. This should conclude the FCP started on rust-lang#74372 and... Closes rust-lang#74372
alexcrichton
force-pushed
the
wasm-simd-stable
branch
from
858f161
to
e05bb26
Compare
|
@bors: r=Amanieu |
|
📌 Commit e05bb26 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
@alexcrichton Would you be willing to post a PR to update the documentation for this? I think it would go here as a new table for wasm. And if I'm reading this right, it would just need one entry for |
|
Certainly! |
alexcrichton
added a commit
to alexcrichton/reference
that referenced
this pull request
Jun 11, 2021
Also document the `simd128` feature stabilized in rust-lang/rust#86204
alexcrichton
added a commit
to alexcrichton/memchr
that referenced
this pull request
Jun 13, 2021
This commit adds simd acceleration support to the `memmem` module. This is added with the freshly-stabilized support from rust-lang/rust#86204. This mostly just cribs off the generic simd support for 128-bit types built for sse, copying bits and pieces of code here and there. Some refactoring happened internally to help reduce duplication where possible. I ran some initial benchmarks with the `memmem/krate/*` regex and a hacked up single-threaded version of criterion. Some [initial comparisons][compare] using Wasmtime as a runtime do indeed show a lot of improvements, but there are indeed some slowdowns as well. [compare]: https://gist.github.com/alexcrichton/6a72e682e7b6d505ade605359fbe3f2d
alexcrichton
added a commit
to alexcrichton/memchr
that referenced
this pull request
Dec 22, 2021
This commit adds simd acceleration support to the `memmem` module. This is added with the freshly-stabilized support from rust-lang/rust#86204. This mostly just cribs off the generic simd support for 128-bit types built for sse, copying bits and pieces of code here and there. Some refactoring happened internally to help reduce duplication where possible. I ran some initial benchmarks with the `memmem/krate/*` regex and a hacked up single-threaded version of criterion. Some [initial comparisons][compare] using Wasmtime as a runtime do indeed show a lot of improvements, but there are indeed some slowdowns as well. [compare]: https://gist.github.com/alexcrichton/6a72e682e7b6d505ade605359fbe3f2d
alexcrichton
added a commit
to alexcrichton/memchr
that referenced
this pull request
Dec 22, 2021
This commit adds simd acceleration support to the `memmem` module. This is added with the freshly-stabilized support from rust-lang/rust#86204. This mostly just cribs off the generic simd support for 128-bit types built for sse, copying bits and pieces of code here and there. Some refactoring happened internally to help reduce duplication where possible. I ran some initial benchmarks with the `memmem/krate/*` regex and a hacked up single-threaded version of criterion. Some [initial comparisons][compare] using Wasmtime as a runtime do indeed show a lot of improvements, but there are indeed some slowdowns as well. [compare]: https://gist.github.com/alexcrichton/6a72e682e7b6d505ade605359fbe3f2d
alexcrichton
added a commit
to alexcrichton/memchr
that referenced
this pull request
Dec 22, 2021
This commit adds simd acceleration support to the `memmem` module. This is added with the freshly-stabilized support from rust-lang/rust#86204. This mostly just cribs off the generic simd support for 128-bit types built for sse, copying bits and pieces of code here and there. Some refactoring happened internally to help reduce duplication where possible. I ran some initial benchmarks with the `memmem/krate/*` regex and a hacked up single-threaded version of criterion. Some [initial comparisons][compare] using Wasmtime as a runtime do indeed show a lot of improvements, but there are indeed some slowdowns as well. [compare]: https://gist.github.com/alexcrichton/6a72e682e7b6d505ade605359fbe3f2d
BurntSushi
pushed a commit
to BurntSushi/memchr
that referenced
this pull request
Dec 22, 2021
This commit adds simd acceleration support to the `memmem` module. This is added with the freshly-stabilized support from rust-lang/rust#86204. This mostly just cribs off the generic simd support for 128-bit types built for sse, copying bits and pieces of code here and there. Some refactoring happened internally to help reduce duplication where possible. I ran some initial benchmarks with the `memmem/krate/*` regex and a hacked up single-threaded version of criterion. Some [initial comparisons][compare] using Wasmtime as a runtime do indeed show a lot of improvements, but there are indeed some slowdowns as well. [compare]: https://gist.github.com/alexcrichton/6a72e682e7b6d505ade605359fbe3f2d PR #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit performs two changes to stabilize Rust support for
WebAssembly simd intrinsics:
wasm_target_featurefeature gate requirement for thesimd128feature has been removed, stabilizing the name
simd128.This should conclude the FCP started on #74372 and...
Closes #74372