Perf experiment for "Get piece unchecked in `write`" #88571

camsteffen · 2021-09-01T21:54:11Z

Seeing if I can find the cause of the perf regression #83302 by reverting parts.

@bors try @rust-timer queue include=style-servo-debug

rust-highfive · 2021-09-01T21:54:14Z

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

camsteffen · 2021-09-01T21:55:18Z

@bors r? @ghost - eh that didn't work

Mark-Simulacrum · 2021-09-01T22:22:00Z

@bors try @rust-timer queue include=style-servo

rust-timer · 2021-09-01T22:22:01Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-09-01T22:22:08Z

⌛ Trying commit bf164323aa3c5516b301411f7194ca24286297d5 with merge 6234197c9036b92e2061fe61b9d14a6b100556bb...

bors · 2021-09-01T23:46:29Z

☀️ Try build successful - checks-actions
Build commit: 6234197c9036b92e2061fe61b9d14a6b100556bb (6234197c9036b92e2061fe61b9d14a6b100556bb)

rust-timer · 2021-09-01T23:46:31Z

Queued 6234197c9036b92e2061fe61b9d14a6b100556bb with parent 50171c3, future comparison URL.

rust-timer · 2021-09-02T03:55:18Z

Finished benchmarking try commit (6234197c9036b92e2061fe61b9d14a6b100556bb): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

Large improvement in instruction counts (up to -3.6% on incr-patched: b9b3e592dd cherry picked builds of style-servo)
Moderate regression in instruction counts (up to 0.6% on incr-patched: b9b3e592dd cherry picked builds of style-servo)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Avoids two nested `matche`es but widens the scope of the unsafe block.

camsteffen · 2021-09-02T14:22:08Z

@bors try @rust-timer queue

rust-timer · 2021-09-02T14:22:09Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-09-02T14:22:16Z

⌛ Trying commit 1db96e3 with merge fd20cc804e82e71d4bb692b455556865f14d7677...

rust-log-analyzer · 2021-09-02T14:37:45Z

The job x86_64-gnu-llvm-10 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [ui] ui/binop/binops.rs stdout ----
normalized stderr:
warning: unnecessary `unsafe` block
   |
LL |   unsafe {
LL |   unsafe {
   |   ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted

---
To only update this specific test, also pass `--test-args binop/binops.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/binop/binops.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/binops/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/binops/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
warning: unnecessary `unsafe` block
   |
LL |   unsafe {
LL |   unsafe {
   |   ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted



------------------------------------------


---- [ui] ui/closures/2229_closure_analysis/run_pass/unsafe_ptr.rs stdout ----
normalized stderr:
warning: unnecessary `unsafe` block
   |
   |
LL |     let c = || unsafe {
   |                ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted

---
To only update this specific test, also pass `--test-args closures/2229_closure_analysis/run_pass/unsafe_ptr.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/closures/2229_closure_analysis/run_pass/unsafe_ptr.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/2229_closure_analysis/run_pass/unsafe_ptr/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2021" "-Zunstable-options" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/closures/2229_closure_analysis/run_pass/unsafe_ptr/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
warning: unnecessary `unsafe` block
   |
   |
LL |     let c = || unsafe {
   |                ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted



------------------------------------------


---- [ui] ui/union/union-trait-impl.rs#mirunsafeck stdout ----
normalized stderr:
warning: unnecessary `unsafe` block
   |
   |
LL |         unsafe { write!(f, "Oh hai {}", self.a) }
   |         ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted





The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/union/union-trait-impl.mirunsafeck/union-trait-impl.mirunsafeck.stderr
To only update this specific test, also pass `--test-args union/union-trait-impl.rs`


error in revision `mirunsafeck`: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/union/union-trait-impl.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "mirunsafeck" "--error-format" "json" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/union/union-trait-impl.mirunsafeck/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/union/union-trait-impl.mirunsafeck/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
warning: unnecessary `unsafe` block
   |
   |
LL |         unsafe { write!(f, "Oh hai {}", self.a) }
   |         ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted



------------------------------------------


---- [ui] ui/union/union-trait-impl.rs#thirunsafeck stdout ----
normalized stderr:
warning: unnecessary `unsafe` block
   |
   |
LL |         unsafe { write!(f, "Oh hai {}", self.a) }
   |         ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted





The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/union/union-trait-impl.thirunsafeck/union-trait-impl.thirunsafeck.stderr
To only update this specific test, also pass `--test-args union/union-trait-impl.rs`


error in revision `thirunsafeck`: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/union/union-trait-impl.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "thirunsafeck" "--error-format" "json" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/union/union-trait-impl.thirunsafeck/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "thir-unsafeck" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/union/union-trait-impl.thirunsafeck/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
warning: unnecessary `unsafe` block
   |
   |
LL |         unsafe { write!(f, "Oh hai {}", self.a) }
   |         ^^^^^^ unnecessary `unsafe` block
   = note: `#[warn(unused_unsafe)]` on by default

warning: 1 warning emitted

---
test result: FAILED. 11985 passed; 4 failed; 102 ignored; 0 measured; 0 filtered out; finished in 129.14s



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-10/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "10.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker engine executionengine frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcerror orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:13:09

bors · 2021-09-02T15:34:05Z

☀️ Try build successful - checks-actions
Build commit: fd20cc804e82e71d4bb692b455556865f14d7677 (fd20cc804e82e71d4bb692b455556865f14d7677)

rust-timer · 2021-09-02T15:34:06Z

Queued fd20cc804e82e71d4bb692b455556865f14d7677 with parent 6492931, future comparison URL.

rust-timer · 2021-09-02T17:20:17Z

Finished benchmarking try commit (fd20cc804e82e71d4bb692b455556865f14d7677): comparison url.

Summary: ERROR categorizing benchmark run!

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

rust-highfive assigned wesleywiser Sep 1, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2021

Mark-Simulacrum unassigned wesleywiser Sep 1, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 2, 2021

Simplify format_args expansion

1db96e3

Avoids two nested `matche`es but widens the scope of the unsafe block.

camsteffen force-pushed the fmt-unchecked-perf branch from bf16432 to 1db96e3 Compare September 2, 2021 14:21

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 2, 2021

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Sep 2, 2021

camsteffen mentioned this pull request Sep 3, 2021

Get piece unchecked in write #83302

Merged

camsteffen closed this Sep 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perf experiment for "Get piece unchecked in `write`" #88571

Perf experiment for "Get piece unchecked in `write`" #88571

camsteffen commented Sep 1, 2021

rust-highfive commented Sep 1, 2021

camsteffen commented Sep 1, 2021 •

edited

Loading

Mark-Simulacrum commented Sep 1, 2021

rust-timer commented Sep 1, 2021

bors commented Sep 1, 2021

bors commented Sep 1, 2021

rust-timer commented Sep 1, 2021

rust-timer commented Sep 2, 2021

camsteffen commented Sep 2, 2021

rust-timer commented Sep 2, 2021

bors commented Sep 2, 2021

rust-log-analyzer commented Sep 2, 2021

bors commented Sep 2, 2021

rust-timer commented Sep 2, 2021

rust-timer commented Sep 2, 2021

Perf experiment for "Get piece unchecked in write" #88571

Perf experiment for "Get piece unchecked in write" #88571

Conversation

camsteffen commented Sep 1, 2021

rust-highfive commented Sep 1, 2021

camsteffen commented Sep 1, 2021 • edited Loading

Mark-Simulacrum commented Sep 1, 2021

rust-timer commented Sep 1, 2021

bors commented Sep 1, 2021

bors commented Sep 1, 2021

rust-timer commented Sep 1, 2021

rust-timer commented Sep 2, 2021

camsteffen commented Sep 2, 2021

rust-timer commented Sep 2, 2021

bors commented Sep 2, 2021

rust-log-analyzer commented Sep 2, 2021

bors commented Sep 2, 2021

rust-timer commented Sep 2, 2021

rust-timer commented Sep 2, 2021

Perf experiment for "Get piece unchecked in `write`" #88571

Perf experiment for "Get piece unchecked in `write`" #88571

camsteffen commented Sep 1, 2021 •

edited

Loading