Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #88686

Merged
merged 13 commits into from
Sep 6, 2021
Merged

Rollup of 6 pull requests #88686

merged 13 commits into from
Sep 6, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Sep 6, 2021

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

BoxyUwU and others added 13 commits September 2, 2021 21:22
It was previously unclear which should be used when.
SmallVector is long gone, as it's been first replaced
by OneVector in commit e5e6375,
which then has been removed entirely in favour of SmallVec in
commit 130a32f.
Add tests for some const generics issues

closes rust-lang#82956
closes rust-lang#84659
closes rust-lang#86530
closes rust-lang#86535

there is also a random test in here about array repeat expressions that I already had on this branch but it seems to fit the theme of this PR so kept it...

r? `@lcnr`
…htriplett

Document when to use Windows' `symlink_dir` vs. `symlink_file`

It was previously unclear why there are two functions and when they should be used.

Fixes: rust-lang#88635
…ewjasper

Remove SmallVector mention

SmallVector is long gone, as it's been first replaced
by OneVector in commit e5e6375,
which then has been removed entirely in favour of SmallVec in
commit 130a32f.
Correct typo

found while addressing reviewer remarks for rust-lang#88316
Fix typo: needede -> needed

Fix a typo in library/alloc/src/collections/btree/node.rs
@rustbot rustbot added the rollup A PR which is a rollup label Sep 6, 2021
@rylev
Copy link
Member Author

rylev commented Sep 6, 2021

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Sep 6, 2021

@rylev: 🔑 Insufficient privileges: Not in reviewers

@m-ou-se
Copy link
Member

m-ou-se commented Sep 6, 2021

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Sep 6, 2021

📌 Commit 3c4b461 has been approved by m-ou-se

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 6, 2021
@bors
Copy link
Contributor

bors commented Sep 6, 2021

⌛ Testing commit 3c4b461 with merge 13db844...

@bors
Copy link
Contributor

bors commented Sep 6, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 13db844 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 6, 2021
@bors bors merged commit 13db844 into rust-lang:master Sep 6, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 6, 2021
@rylev rylev deleted the rollup-m1tf9ir branch September 6, 2021 16:01
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (13db844): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants