Run no_core rustdoc tests only on Linux
#89171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I don't really feel like playing wack-a-mole with these tests. Can you just change it to |
jyn514
added
A-testsuite
Windows on Macos ARM64 produce linker errors.
hkratz
force-pushed
the
aarch64_macos_rustdoc_ci_fixes
branch
from
3dcf5b9
to
da6f01d
Compare
Done. |
hkratz
changed the title
no_core rustdoc tests on aarch64-apple-darwin due to linker errorno_core rustdoc tests only on Linux
jyn514
added
S-waiting-on-review
|
(this is waiting on me running this locally on a Linux host and making sure it actually runs rather than being ignored - if you want to speed it up and have a Linux machine you could do that yourself, otherwise I'll try to get to it by this weekend.) |
I can confirm that the test now runs on Linux and is ignored on Macos. Linux: Macos: |
|
@bors r+ rollup Thanks! |
|
📌 Commit da6f01d has been approved by |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 23, 2021
…i_fixes, r=jyn514
Run `no_core` rustdoc tests only on Linux
I don't think this is really worth investigating further so I just disabled them.
They currently fail like this:
```
error: linking with `cc` failed: exit status: 1
|
= note: "cc" "-Wl,-exported_symbols_list,/var/folders/pg/gjhzdz7n361f0pv665d0723w0000gn/T/rustcPUsMpx/list" "-arch" "arm64" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary/my-core.my_core.9f3c60de-cgu.0.rcgu.o" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary/my-core.50fu2g9urkmisdsg.rcgu.o" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/native/rust-test-helpers" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/stage1/lib/rustlib/aarch64-apple-darwin/lib" "-L" "/Users/hans/dev/rust/build/aarch64-apple-darwin/stage1/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/Users/hans/dev/rust/build/aarch64-apple-darwin/test/rustdoc/intra-doc/prim-methods-external-core/auxiliary/libmy_core.dylib" "-Wl,-dead_strip" "-dynamiclib" "-Wl,-dylib" "-Wl,-install_name" "-Wl,`@rpath/libmy_core.dylib"` "-nodefaultlibs"
= note: ld: dynamic main executables must link with libSystem.dylib for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
r? `@jyn514`
This was referenced Sep 23, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2021
…ingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#88612 (Add a better error message for rust-lang#39364) - rust-lang#89023 (Resolve issue : Somewhat confusing error with extended_key_value_attributes) - rust-lang#89148 (Suggest `_` in turbofish if param will be inferred from fn argument) - rust-lang#89171 (Run `no_core` rustdoc tests only on Linux) - rust-lang#89176 (Change singular to plural) - rust-lang#89184 (Temporarily rename int_roundings functions to avoid conflicts) - rust-lang#89200 (Fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is really worth investigating further so I just disabled them.
They currently fail like this:
r? @jyn514