Make diangostic item naming consistent #89479
Conversation
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This seems "ok", I guess. I think it probably affects clippy most (though it looks like you're on the clippy team) but I'll r? @Manishearth @bors rollup=never (could have perf effects due to changes in the symbol interning map) |
camsteffen
force-pushed
the
diag-naming
branch
from
16f8b76
to
eec856b
Compare
|
I'm happy with such a change on the clippy side, but I'll review when I get the chance |
|
@bors r+ p=1 we should do an early sync after this, perhaps |
|
📌 Commit eec856b has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (77f1e50): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Fix ICE when compiling nightly std/rustc on beta compiler Fix rust-lang#89775 rust-lang#89479 renames a lot of diagnostic items, but it happens that the beta compiler assumes that there must be DefId with `rustc_diagnostic_item = "send_trait"`, causing an ICE when compiling stage 0 std or stage 1 compiler. So gate it with `cfg(bootstrap)`. The unwrap is also removed, so that existence of the diagnostic item is not required. I ripgreped the code base and this seems the only place where `unwrap` is called on the return value of `get_diagnostic_item`.
Right now there is about a 50/50 split of naming diagnostic items as
vec_typevsVec. So it is hard to guess a diagnostic item name with confidence. I know it's not great to change these retroactively, but I think it will be much easier to maintain consistency after consistency is established.