Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Miri #89646

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Update Miri #89646

merged 1 commit into from
Oct 8, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 7, 2021

Fixes #89612.

r? @RalfJung

@camelid camelid added the A-miri Area: The miri tool label Oct 7, 2021
@rust-highfive
Copy link
Collaborator

Some changes occured to the Miri submodule

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2021
@camelid
Copy link
Member Author

camelid commented Oct 7, 2021

I've never updated a tool submodule before, so let me know if I did this correctly :)

@RalfJung
Copy link
Member

RalfJung commented Oct 7, 2021

It looks just right, thanks a lot for the help. :)
@bors r+ p=1

@bors
Copy link
Contributor

bors commented Oct 7, 2021

📌 Commit 9771803 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2021
@bors
Copy link
Contributor

bors commented Oct 8, 2021

⌛ Testing commit 9771803 with merge c2171ee...

@bors
Copy link
Contributor

bors commented Oct 8, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing c2171ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2021
@bors bors merged commit c2171ee into rust-lang:master Oct 8, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 8, 2021
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #89646!

Tested on commit c2171ee.
Direct link to PR: #89646

🎉 miri on windows: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 8, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#89646!
523e1fb 
Tested on commit rust-lang/rust@c2171ee.
Direct link to PR: <rust-lang/rust#89646>

🎉 miri on windows: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @eddyb @RalfJung @oli-obk).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c2171ee): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@camelid camelid deleted the miri-up branch October 8, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
A-miri Area: The miri tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#89608
6 participants
@camelid @rust-highfive @RalfJung @bors @rust-timer @rustbot