Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL for scrape-examples.js in rustdoc page template #90517

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Fix URL for scrape-examples.js in rustdoc page template #90517

merged 2 commits into from
Nov 3, 2021

Conversation

willcrichton
Copy link
Contributor

Also adds line numbers to URLs in the "additional examples" section of rustdoc.

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2021
@willcrichton willcrichton force-pushed the example-analyzer branch 2 times, most recently from 3cdb1fd to 6fa9c38 Compare November 3, 2021 02:12
jyn514
jyn514 reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the nit :)

src/librustdoc/html/render/mod.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Nov 3, 2021 •
edited
Loading

@bors delegate=willcrichton (please use r=jyn514, not r+, and wait for CI to pass first)

@bors
Copy link
Contributor

bors commented Nov 3, 2021

✌️ @willcrichton can now approve this pull request

@camelid camelid added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 3, 2021
@willcrichton
Copy link
Contributor Author

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Nov 3, 2021

📌 Commit ce943d2 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2021
@bors
Copy link
Contributor

bors commented Nov 3, 2021

⌛ Testing commit ce943d2 with merge 473eaa4...

@bors
Copy link
Contributor

bors commented Nov 3, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 473eaa4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2021
@bors bors merged commit 473eaa4 into rust-lang:master Nov 3, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 3, 2021
@jyn514 jyn514 deleted the example-analyzer branch November 3, 2021 15:23
@jyn514 jyn514 restored the example-analyzer branch November 3, 2021 15:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (473eaa4): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@willcrichton @jyn514 @bors @rust-timer @rust-highfive @camelid @rustbot