Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create real parser for search queries #90630

Merged
merged 28 commits into from
Apr 21, 2022
Merged

Create real parser for search queries #90630

merged 28 commits into from
Apr 21, 2022

Commits on Apr 18, 2022

  1. Greatly improve rustdoc search

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    be41750 View commit details
    Browse the repository at this point in the history

  2. Update search engine and parser to error when quotes are used on quer… 

    …ies with more than one element.
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    3aeef67 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    0f51652 View commit details
    Browse the repository at this point in the history

  4. Add possibility to check parsed query

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    7cefee0 View commit details
    Browse the repository at this point in the history

  5. Add parser tests

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f5833e7 View commit details
    Browse the repository at this point in the history

  6. Improve naming of "val" field

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    bbcf176 View commit details
    Browse the repository at this point in the history

  7. * If type filter is in quotes, throw an error. 

    * If there are generics, don't allow to have quotes.
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    51de26c View commit details
    Browse the repository at this point in the history

  8. Add query syntax for the parser

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    99c5394 View commit details
    Browse the repository at this point in the history

  9. * Greatly improve the rustdoc search parser source code 

    * Move all functions outside parseQuery
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    264064d View commit details
    Browse the repository at this point in the history

  10. Make query parser more strict and improve display of errors

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    99d5520 View commit details
    Browse the repository at this point in the history

  11. Simplify parser syntax

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    4929733 View commit details
    Browse the repository at this point in the history

  12. Improve documentation and add some explanations in the code

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    c7de1a1 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions: 

     * Forbid generics without a path (so "<p>" is forbidden).
 * Change `handleSingleArg` so that it takes `results_others`, `results_in_args` and `results_returned` as arguments instead of using the "global" variables.
 * Change `createQueryElement` so that it returns the newly created element instead of taking `elems` as argument.
 * Improve documentation
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    699ae36 View commit details
    Browse the repository at this point in the history

  14. Replace unneeded use of regex with a simple if

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f9251ee View commit details
    Browse the repository at this point in the history

  15. Add isIdentCharacter function to ensure that unexpected characters ar… 

    …e handled correctly
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8e29ed4 View commit details
    Browse the repository at this point in the history

  16. Forbid rustdoc search query to end with ->

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    1f5c4c2 View commit details
    Browse the repository at this point in the history

  17. Improve the BNF description a bit and fix some issues

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    da829d8 View commit details
    Browse the repository at this point in the history

  18. Handle separators in their own functions and fix missing handling of … 

    …tabs
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e03a950 View commit details
    Browse the repository at this point in the history

  19. Update the eBNF to allow generics bracket to not be closed if it's EOF

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    51b4005 View commit details
    Browse the repository at this point in the history

  20. Add tests for paths

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ab9cf32 View commit details
    Browse the repository at this point in the history

  21. Remove unnecessary elem.name.length === 0 since the rustdoc search … 

    …eBNF does not allow elements without a name
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a6051c7 View commit details
    Browse the repository at this point in the history

  22. Parse idents the same way in both quote string elements and "normal" … 

    …elements
    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    6f35475 View commit details
    Browse the repository at this point in the history

  23. Add more tests for quote errors

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    da363b2 View commit details
    Browse the repository at this point in the history

  24. Fix some corner cases

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d7d538a View commit details
    Browse the repository at this point in the history

  25. Add an extra check over filter type

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    299e8ee View commit details
    Browse the repository at this point in the history

  26. Add test to ensure that keywords in path are working

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5c6c1e1 View commit details
    Browse the repository at this point in the history

  27. Correctly handle single :

    @GuillaumeGomez
    GuillaumeGomez committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    8d0e10c View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Extend handleSingleArg documentation

    @GuillaumeGomez
    GuillaumeGomez committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4d26bde View commit details
    Browse the repository at this point in the history