Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type error go brrrrrrrr #90646

Merged
merged 1 commit into from
Nov 7, 2021
Merged

type error go brrrrrrrr #90646

merged 1 commit into from
Nov 7, 2021

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Nov 6, 2021

Fixes #90444

when we relate something like:
fn(fn((), (), u32)) with fn(fn((), (), ()))
we relate the inner fn ptrs:
fn((), (), u32) with fn((), (), ())
yielding a TypeError::ArgumentSorts(_, 2) which we then use as the TypeError for the fn(fn(..)) which later causes the ICE as the 2 does not correspond to any input or output types in fn(_)

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2021
@estebank
Copy link
Contributor

estebank commented Nov 6, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Nov 6, 2021

📌 Commit abb9a98 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2021
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#90487 (Add a chapter on reading Rustdoc output)
 - rust-lang#90508 (Apply adjustments for field expression even if inaccessible)
 - rust-lang#90627 (Suggest dereference of `Box` when inner type is expected)
 - rust-lang#90642 (use matches!() macro in more places)
 - rust-lang#90646 (type error go brrrrrrrr)
 - rust-lang#90649 (Run reveal_all on MIR when inlining is activated.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43fee0e into rust-lang:master Nov 7, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something funky crashes typeck (stable and nightly)
5 participants