Remove bigint_helper_methods for *signed* types #90848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are working well for *unsigned* types, for the the signed ones there are a bunch of questions about what the semantics and API should be. And for the main "helpers for big integer implementations" use, there's no need for the signed versions anyway. And there are plenty of other methods which exist for unsigned types but not signed ones, like `next_power_of_two`, so this isn't unusual. Fixes 90541
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
scottmcm
added
B-unstable
|
@bors r+ |
|
📌 Commit 6323f92 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#85766 (Stabilize File::options()) - rust-lang#88601 (Implement `Termination` for `Result<Infallible, E>`) - rust-lang#90058 (Stabilize -Z strip as -C strip) - rust-lang#90790 (Fix standard library test with read_link) - rust-lang#90834 (Android is not GNU) - rust-lang#90835 (Rename WASI's `is_character_device` to `is_char_device`.) - rust-lang#90837 (Move some tests to more reasonable directories - 9) - rust-lang#90848 (Remove bigint_helper_methods for *signed* types) - rust-lang#90892 (fix ICE on Miri/CTFE copy of half a pointer) - rust-lang#90909 (disable portable SIMD tests in Miri) Failed merges: - rust-lang#90128 (Stabilize -Z symbol-mangling-version=v0 as -C symbol-mangling-version=v0) r? `@ghost` `@rustbot` modify labels: rollup
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inspired by @cuviper's comment @ #90541 (comment)
These are working well for unsigned types, so keep those, but for the the signed ones there are a bunch of questions about what the semantics and API should be. For the main "helpers for big integer implementations" use, there's no need for the signed versions anyway. There are plenty of other methods which exist for unsigned types but not signed ones, like
next_power_of_two, so this isn't unusual.Fixes #90541
Tracking issue #85532