Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include lint errors in error count for -Ztreat-err-as-bug #91425

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Include lint errors in error count for -Ztreat-err-as-bug #91425

merged 1 commit into from
Dec 1, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 1, 2021

This was a regression from #87337;
the panic_if_treat_err_as_bug function only checked the number of hard
errors, not the number of lint errors.

r? @oli-obk

@jyn514
Include lint errors in error count for -Ztreat-err-as-bug
9de8a4a 
This was a regression from rust-lang#87337;
the `panic_if_treat_err_as_bug` function only checked the number of hard
errors, not the number of lint errors.
@jyn514 jyn514 added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. requires-nightly This issue requires a nightly compiler in some way. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Dec 1, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Dec 1, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 1, 2021

📌 Commit 9de8a4a has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2021
@bors
Auto merge of rust-lang#91433 - matthiaskrgr:rollup-118ql06, r=matthi…
48a5999 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#88502 (Add slice take methods)
 - rust-lang#91313 (expand: Turn `ast::Crate` into a first class expansion target)
 - rust-lang#91424 (Update LLVM with patches for better llvm-cov diagnostics)
 - rust-lang#91425 (Include lint errors in error count for `-Ztreat-err-as-bug`)
 - rust-lang#91430 (Add tests for `normalize-docs` overflow errors)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4a6e8a9 into rust-lang:master Dec 1, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 1, 2021
@jyn514 jyn514 mentioned this pull request Sep 26, 2022
Closed
@jyn514 jyn514 deleted the treat-lint-err-as-bug branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. requires-nightly This issue requires a nightly compiler in some way. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @oli-obk @bors @rust-highfive @rustbot