Rollup of 15 pull requests #91941
Closed
Rollup of 15 pull requests #91941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resulting profile will include the crate name and will be stored in the `--out-dir` directory. This implementation makes it convenient to use LLVM time trace together with cargo, in the contrast to the previous implementation which would overwrite profiles or store them in `.cargo/registry/..`.
This avoids a needless query invocation
See rust-lang#91867 for more information.
…i-obk Recover on invalid operators `<>` and `<=>` Thanks to rust-lang#89871 for showing me how to do this. Next, I think it'd be nice to recover on `<=>` too, like rust-lang#89871 intended, if this even works.
Iterator::cycle() — document empty iterator special case
Use `OutputFilenames` to generate output file for `-Zllvm-time-trace` The resulting profile will include the crate name and will be stored in the `--out-dir` directory. This implementation makes it convenient to use LLVM time trace together with cargo, in the contrast to the previous implementation which would overwrite profiles or store them in `.cargo/registry/..`.
…wiser Remove `in_band_lifetimes` from `rustc_borrowck` See rust-lang#91867 for more information.
…times-from-rustc-typeck, r=jackh726 Remove `in_band_lifetimes` from `rustc_typeck` Joining in on the effort to remove the `in_band_lifetimes` features, as described in issue rust-lang#91867.
core: minor `Option` doc correction
Handle unordered const/ty generics for object lifetime defaults *feel like I should have a PR description but cant think of what to put here* r? `@lcnr`
…stc_symbol_mangling, r=jackh726 Remove `in_band_lifetimes` from `rustc_symbol_mangling` Helping out with rust-lang#91867
…stc_trait_selection, r=petrochenkov Remove `in_band_lifetimes` from `rustc_trait_selection` Another one for rust-lang#91867
…es_library_proc_macro, r=petrochenkov Removed `in_band_lifetimes` from `library\proc_macro` Issue [rust-lang#91867](rust-lang#91867) This is my first try, I followed the instructions given. Fixed all the errors that were thrown while compiling. Compiled with stage 0,1, and 2 all of them compiled successfully.
…crum Add another regression test for unnormalized fn args with Self Closes rust-lang#91899
Fix a bunch of typos I hope that none of these files is not supposed to be modified. FYI, I opened separate PRs for typos in submodules, in the respective repositories * rust-lang/stdarch#1267 * rust-lang/backtrace-rs#455
…-constification-begins, r=oli-obk
Constify `bool::then{,_some}`
Note on `~const Drop`: it has no effect when called from runtime functions, when called from const contexts, the trait system ensures that the type can be dropped in const contexts.
Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp` This avoids a needless query invocation
…_llvm, r=davidtwco Remove `in_band_lifetimes` from `rustc_codegen_llvm` See rust-lang#91867 for more information. This one took a while. This crate has dozens of functions not associated with any type, and most of them were using in-band lifetimes for `'ll` and `'tcx`.
rustbot
added
T-compiler
|
@bors r+ rollup=never p=15 |
|
📌 Commit 71b2c82 has been approved by |
bors
added
the
S-waiting-on-bors
|
Hmm, I'm not sure if it's such a good idea to roll up so many of the |
|
Ah, in theory this could have |
|
I'm not sure; it could be fine, but it may not. 🤷 |
|
Should we do a perf-run on the rollup? 🙃 |
|
Well sometimes different perf changes can cancel out. Your choice :) |
|
MMh ok, I'll try to split then up a bit among different rollup.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
<>and<=>#91597 (Recover on invalid operators<>and<=>)OutputFilenamesto generate output file for-Zllvm-time-trace#91868 (UseOutputFilenamesto generate output file for-Zllvm-time-trace)in_band_lifetimesfromrustc_borrowck#91879 (Removein_band_lifetimesfromrustc_borrowck)in_band_lifetimesfromrustc_typeck#91882 (Removein_band_lifetimesfromrustc_typeck)Optiondoc correction #91886 (core: minorOptiondoc correction)in_band_lifetimesfromrustc_symbol_mangling#91901 (Removein_band_lifetimesfromrustc_symbol_mangling)in_band_lifetimesfromrustc_trait_selection#91904 (Removein_band_lifetimesfromrustc_trait_selection)in_band_lifetimesfromlibrary\proc_macro#91906 (Removedin_band_lifetimesfromlibrary\proc_macro)bool::then{,_some}#91918 (Constifybool::then{,_some})tcx.def_path_hashinExistentialPredicate.stable_cmp#91920 (Usetcx.def_path_hashinExistentialPredicate.stable_cmp)in_band_lifetimesfromrustc_codegen_llvm#91931 (Removein_band_lifetimesfromrustc_codegen_llvm)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup