Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update char signess for openbsd #92061

Merged
merged 2 commits into from
Mar 3, 2022
Merged

update char signess for openbsd #92061

merged 2 commits into from
Mar 3, 2022

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Dec 18, 2021

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2021
@sanxiyn sanxiyn added the O-openbsd Operating system: OpenBSD label Jan 5, 2022
@semarie
Copy link
Contributor Author

semarie commented Jan 6, 2022

ping ?

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2022
@bors
Copy link
Contributor

bors commented Jan 28, 2022

☔ The latest upstream changes (presumably #93390) made this pull request unmergeable. Please resolve the merge conflicts.

@semarie
Copy link
Contributor Author

semarie commented Jan 28, 2022

updated commit after #91641

@bors
Copy link
Contributor

bors commented Jan 29, 2022

☔ The latest upstream changes (presumably #93351) made this pull request unmergeable. Please resolve the merge conflicts.

@semarie semarie closed this Jan 29, 2022
@semarie semarie reopened this Jan 29, 2022
@semarie semarie changed the title update libc to 0.2.112 and update char signess for openbsd update char signess for openbsd Jan 29, 2022
@semarie
Copy link
Contributor Author

semarie commented Jan 29, 2022

updated commit after #93351

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@semarie
Copy link
Contributor Author

semarie commented Jan 29, 2022 •
edited
Loading

the CI failure doesn't seems related. Lot of others CI actions (without my changes) are failing the same way. See #93384

@semarie
Copy link
Contributor Author

semarie commented Feb 16, 2022

ping ?

@bors
Copy link
Contributor

bors commented Mar 2, 2022

☔ The latest upstream changes (presumably #94514) made this pull request unmergeable. Please resolve the merge conflicts.

@semarie
update char signess for openbsd
3768f0b 
adds more archs for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@semarie
Copy link
Contributor Author

semarie commented Mar 2, 2022

updated commit after #94503

@joshtriplett
Copy link
Member

joshtriplett commented Mar 2, 2022 •
edited
Loading

I don't know OpenBSD (and I don't think other reviewers do either), but this seems reasonable given that it matches the same architecture list for other target OSes.

On the assumption that this is likely to remain true, could you just merge this list with the one for freebsd, since it now matches the target list exactly?

r=me with that change.

@semarie
Copy link
Contributor Author

semarie commented Mar 2, 2022

I manually checked the char signess for all the platforms, or by directly check on the hardware, or with clang (and crosscompilation).

$ clang -target riscv64-unknown-openbsd -x c -dM -E - </dev/null | grep _CHAR_
#define __CHAR_BIT__ 8
#define __CHAR_UNSIGNED__ 1
#define __CLANG_ATOMIC_CHAR_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR_LOCK_FREE 2

$ clang -target x86_64-unknown-openbsd -x c -dM -E - </dev/null | grep _CHAR_
#define __CHAR_BIT__ 8
#define __CLANG_ATOMIC_CHAR_LOCK_FREE 2
#define __GCC_ATOMIC_CHAR_LOCK_FREE 2

Technically, there is no requirement for char signess to be the same, but as it is the case currently, I will merge them.
thanks

@semarie
Copy link
Contributor Author

semarie commented Mar 2, 2022

I have merged freebsd and openbsd definition.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 2, 2022

📌 Commit fa8e1be has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#92061 - semarie:openbsd-archs, r=joshtriplett
5afcfac 
update char signess for openbsd

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#92061 - semarie:openbsd-archs, r=joshtriplett
d840a6e 
update char signess for openbsd

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#92061 - semarie:openbsd-archs, r=joshtriplett
e7a6375 
update char signess for openbsd

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2022
@matthiaskrgr
Rollup merge of rust-lang#92061 - semarie:openbsd-archs, r=joshtriplett
eee74bf 
update char signess for openbsd

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 2, 2022
@Dylan-DPC
Rollup merge of rust-lang#92061 - semarie:openbsd-archs, r=joshtriplett
1a5f884 
update char signess for openbsd

it adds more archs support for openbsd: arm, mips64, powerpc, powerpc64, and riscv64.
This was referenced Mar 2, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2022
@bors
Auto merge of rust-lang#94541 - Dylan-DPC:rollup-564wbq3, r=Dylan-DPC
2f8d1a8 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#92061 (update char signess for openbsd)
 - rust-lang#93072 (Compatible variants suggestion with desugaring)
 - rust-lang#93354 (Add documentation about `BorrowedFd::to_owned`.)
 - rust-lang#93663 (Rename `BorrowedFd::borrow_raw_fd` to `BorrowedFd::borrow_raw`.)
 - rust-lang#94375 (Adt copy suggestions)
 - rust-lang#94433 (Improve allowness of the unexpected_cfgs lint)
 - rust-lang#94499 (Documentation was missed when demoting Windows XP to no_std only)
 - rust-lang#94505 (Restore the local filter on mono item sorting)
 - rust-lang#94529 (Unused doc comments blocks)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a83021b into rust-lang:master Mar 3, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 3, 2022
@semarie semarie deleted the openbsd-archs branch August 26, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
O-openbsd Operating system: OpenBSD S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@semarie @rust-highfive @bors @rust-log-analyzer @joshtriplett @sanxiyn @camelid @rustbot