Remove &self from PrintState::to_string

[dtolnay]

The point of PrintState::to_string is to create a State and evaluate the caller's closure on it:

rust/compiler/rustc_ast_pretty/src/pprust/state.rs

Lines 868 to 872 in e9fbe79

	fn to_string(f: impl FnOnce(&mut State<'_>)) -> String {
	let mut printer = State::new();
	f(&mut printer);
	printer.s.eof()
	}

Making the caller also construct and pass in a State, which is then ignored, was confusing.

[rust-highfive]

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

[michaelwoerister]

Looks like a straightforward improvement to me. Thanks, @dtolnay!

@bors r+ rollup

[bors]

📌 Commit e9fbe79 has been approved by michaelwoerister