-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] backports #93922
Merged
Merged
[beta] backports #93922
Commits on Feb 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for de2f0d5 - Browse repository at this point
Copy the full SHA de2f0d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5db4705 - Browse repository at this point
Copy the full SHA 5db4705View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79ee164 - Browse repository at this point
Copy the full SHA 79ee164View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5140d6d - Browse repository at this point
Copy the full SHA 5140d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22f1800 - Browse repository at this point
Copy the full SHA 22f1800View commit details
Commits on Feb 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8b2c687 - Browse repository at this point
Copy the full SHA 8b2c687View commit details -
Fix hashing for windows paths containing a CurDir component
* the logic only checked for / but not for \ * verbatim paths shouldn't skip items at all since they don't get normalized * the extra branches get optimized out on unix since is_sep_byte is a trivial comparison and is_verbatim is always-false * tests lacked windows coverage for these cases That lead to equal paths not having equal hashes and to unnecessary collisions.
Configuration menu - View commit details
-
Copy full SHA for d521a81 - Browse repository at this point
Copy the full SHA d521a81View commit details -
A fix applied to std::Path::hash triggers a miscompilation/assert in LLVM in this test on wasm32. The miscompilation appears to pre-existing. Reverting some previous changes done std::Path also trigger it and slight modifications such as changing the test path from "a" to "ccccccccccc" also make it pass, indicating it's very flaky. Since the fix is for a higher-tier platform than wasm it takes precedence.
Configuration menu - View commit details
-
Copy full SHA for 0ac18e7 - Browse repository at this point
Copy the full SHA 0ac18e7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.