Remove --extern-location and all associated code
#96086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--extern-location` was an experiment to investigate the best way to generate useful diagnostics for unused dependency warnings by enabling a build system to identify the corresponding build config. While I did successfully use this, I've since been convinced the alternative `--json unused-externs` mechanism is the way to go, and there's no point in having two mechanisms with basically the same functionality. This effectively reverts rust-lang#72603
rustbot
added
the
T-compiler
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I posted a to irlo in case someone is actually using this functionality, but AFAIK I'm the only one: https://internals.rust-lang.org/t/anyone-using-extern-location/16480 Also cc @petrochenkov @nikomatsakis as reviewers on #72603. |
davidtwco
approved these changes
Apr 19, 2022
|
Do we want to wait a little longer for anyone to tell us they are using this? r=me otherwise |
|
I think we're good to go. We can always revert this PR if someone really needs it. |
|
@bors r=davidtwco |
|
📌 Commit 1be1157 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 19, 2022
…dtwco Remove `--extern-location` and all associated code `--extern-location` was an experiment to investigate the best way to generate useful diagnostics for unused dependency warnings by enabling a build system to identify the corresponding build config. While I did successfully use this, I've since been convinced the alternative `--json unused-externs` mechanism is the way to go, and there's no point in having two mechanisms with basically the same functionality. This effectively reverts rust-lang#72603
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 19, 2022
…dtwco Remove `--extern-location` and all associated code `--extern-location` was an experiment to investigate the best way to generate useful diagnostics for unused dependency warnings by enabling a build system to identify the corresponding build config. While I did successfully use this, I've since been convinced the alternative `--json unused-externs` mechanism is the way to go, and there's no point in having two mechanisms with basically the same functionality. This effectively reverts rust-lang#72603
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#94493 (Improved diagnostic on failure to meet send bound on future in a foreign crate) - rust-lang#95809 (Fix typo in bootstrap.py) - rust-lang#96086 (Remove `--extern-location` and all associated code) - rust-lang#96089 (`alloc`: make `vec!` unavailable under `no_global_oom_handling`) - rust-lang#96122 (Fix an invalid error for a suggestion to add a slice in pattern-matching) - rust-lang#96142 (Stop using CRATE_DEF_INDEX outside of metadata encoding.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
facebook-github-bot
pushed a commit
to facebook/buck
that referenced
this pull request
Apr 20, 2022
Summary: `--extern-location` was an experimental option in rustc to pass tool diagnostic information through rustc. It was used to pass location information for unused dependencies from Buck via rustc for consumption by rustfixdeps. This was removed in upstream rust in rust-lang/rust#96086 so remove support for it here. Reviewed By: cjhopman fbshipit-source-id: 3509c3b2680a3a86fc782839f2a12312674f9d52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--extern-locationwas an experiment to investigate the best way togenerate useful diagnostics for unused dependency warnings by enabling a
build system to identify the corresponding build config.
While I did successfully use this, I've since been convinced the
alternative
--json unused-externsmechanism is the way to go, andthere's no point in having two mechanisms with basically the same
functionality.
This effectively reverts #72603