[fuchsia] Add implementation for current_exe
#96193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rustbot
added
the
T-libs
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @tmandry |
This comment has been minimized.
This comment has been minimized.
tmandry
reviewed
Apr 18, 2022
djkoloski
force-pushed
the
fuchsia_current_exe
branch
from
3c45245
to
f5c09f4
Compare
This comment has been minimized.
This comment has been minimized.
djkoloski
force-pushed
the
fuchsia_current_exe
branch
from
f5c09f4
to
1785da0
Compare
tmandry
reviewed
Apr 19, 2022
|
@bors delegate+ rollup
|
|
✌️ @djkoloski can now approve this pull request |
|
📌 Commit 1785da01c93ad094bab177438fbbbfcc046ee725 has been approved by `tmandry`` |
bors
added
S-waiting-on-bors
This implementation returns a best attempt at the current exe path. On fuchsia, fdio will always use `argv[0]` as the process name and if it is not set then an error will be returned. Because this is not guaranteed to be the case, this implementation returns an error if `argv` does not contain any elements.
djkoloski
force-pushed
the
fuchsia_current_exe
branch
from
1785da0
to
eb6b6a8
Compare
|
@bors r=tmandry |
|
📌 Commit eb6b6a8 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#90630 (Create real parser for search queries) - rust-lang#96193 ([fuchsia] Add implementation for `current_exe`) - rust-lang#96196 (Remove assertion that all paths in `ShouldRun` exist) - rust-lang#96228 (Fix locations for intrinsics impls and change to links) - rust-lang#96236 (Add an explicit `Span` field to `OutlivesConstraint`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation returns a best attempt at the current exe path. On
fuchsia, fdio will always use
argv[0]as the process name and if it isnot set then an error will be returned. Because this is not guaranteed
to be the case, this implementation returns an error if
argvdoes notcontain any elements.