Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #96502

Closed
wants to merge 23 commits into from
Closed

Commits on Apr 25, 2022

  1. std: directly use pthread in UNIX parker implementation

    Mutex and Condvar are being replaced by more efficient implementations, which need thread parking themselves (see rust-lang#93740). Therefore use the pthread synchronization primitives directly. Also, avoid allocating because the Parker struct is being placed in an Arc anyways.
    joboet committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    54daf49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb55cdc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    519dd8e View commit details
    Browse the repository at this point in the history
  4. update lockfile

    pvdrz committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    d6da5fb View commit details
    Browse the repository at this point in the history
  5. fix formatting

    pvdrz committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    5874b09 View commit details
    Browse the repository at this point in the history
  6. remove old code

    pvdrz committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    530f4dc View commit details
    Browse the repository at this point in the history
  7. add struct_warn method

    pvdrz committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    2e261a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. avoid format!

    pvdrz committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    35b42cb View commit details
    Browse the repository at this point in the history
  2. move AmbigousPlus outside

    pvdrz committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    6c3e793 View commit details
    Browse the repository at this point in the history
  3. separate messages by a newline

    pvdrz committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1e35bab View commit details
    Browse the repository at this point in the history
  4. Add more diagnostic items

    Serial-ATA committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    2a6a370 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Update ui test

    Serial-ATA committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    a1e0cfa View commit details
    Browse the repository at this point in the history
  2. rename sum_with_parens

    pvdrz committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    e7ae9eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    332f326 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b71201 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2c94218 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d9240d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Rollup merge of rust-lang#95312 - marmeladema:tests-for-issue-95305, …

    …r=jackh726
    
    Ensure that `'_` and GAT yields errors
    
    Fixes rust-lang#95305
    
    `@bors` r? `@jackh726`
    Dylan-DPC committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    a67b394 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#96302 - Serial-ATA:more-diagnostic-items, r…

    …=manishearth
    
    Add more diagnostic items
    
    This just adds a handful diagnostic items I noticed were missing.
    
    Would it be worth doing this for all of the remaining types? I'm willing to do it if it'd be helpful.
    Dylan-DPC committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    bccac01 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#96393 - joboet:pthread_parker, r=thomcc

    std: directly use pthread in UNIX parker implementation
    
    `Mutex` and `Condvar` are being replaced by more efficient implementations, which need thread parking themselves (see rust-lang#93740). Therefore we should use the `pthread` synchronization primitives directly. Also, we can avoid allocating the mutex and condition variable because the `Parker` struct is being placed in an `Arc` anyways.
    
    This basically is just a copy of the current `Mutex` and `Condvar` code, which will however be removed (again, see rust-lang#93740). An alternative implementation could be to use dedicated private `OsMutex` and `OsCondvar` types, but all the other platforms supported by std actually have their own thread parking primitives.
    
    I used `Pin` to guarantee a stable address for the `Parker` struct, while the current implementation does not, rather using extra unsafe declaration. Since the thread struct is shared anyways, I assumed this would not add too much clutter while being clearer.
    Dylan-DPC committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ef079b8 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#96405 - pvdrz:ambiguous-plus-diagnostic, r=…

    …davidtwco
    
    Migrate ambiguous plus diagnostic to the new derive macro
    
    r? ``@davidtwco`` ``@jyn514``
    Dylan-DPC committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    16d029b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96409 - marmeladema:fix-nll-introduce-named…

    …-lifetime-suggestion, r=jackh726
    
    Recover suggestions to introduce named lifetime under NLL
    
    Fixes rust-lang#96157
    
    r? `@jackh726`
    
    Built on top of rust-lang#96385 so only the second commit is relevant
    Dylan-DPC committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    021a4ff View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96480 - user-simon:patch-1, r=Dylan-DPC

    Fixed grammatical error in example comment
    
    Added missing "we" in sentence.
    Dylan-DPC committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    439d24e View commit details
    Browse the repository at this point in the history