Fix the x.py clippy command
#96829
Merged
Fix the x.py clippy command
#96829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I don't think this is the correct fix. It reports that |
|
@bors delegate=jyn514 I agree it's likely not the right fix, but depending on how complicated that is may be a good stopgap in the meantime to fix the regression. I'll let you make the call there. |
|
✌️ @jyn514 can now approve this pull request |
Err, apparently this is true? I was confused how clippy works I think. I agree this is the right fix, then. @bors r+ rollup |
|
📌 Commit c64cf27 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#96617 (Fix incorrect syntax suggestion with `pub async fn`) - rust-lang#96828 (Further elaborate the lack of guarantees from `Hasher`) - rust-lang#96829 (Fix the `x.py clippy` command) - rust-lang#96830 (Add and tweak const-generics tests) - rust-lang#96835 (Add more eslint rules) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96826, confirmed clippy runs correctly on local
r? @Mark-Simulacrum