Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_some_and quite a lot #98427

Closed
wants to merge 3 commits into from
Closed

Use is_some_and quite a lot #98427

wants to merge 3 commits into from

Conversation

camsteffen
Copy link
Contributor

Tracking issue for is_some_and: #93050

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 23, 2022
@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

Some changes occurred in clean/types.rs.

cc @camelid

@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2022
@camsteffen camsteffen closed this Jun 23, 2022
@camsteffen camsteffen reopened this Jun 23, 2022
camelid
camelid approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustdoc changes look good to me.

@joshtriplett
Copy link
Member

Looks great to me.

@Dylan-DPC
Copy link
Member

@bors rollup=never

@camsteffen
Copy link
Contributor Author

I'd be okay with holding this open while we discuss a possible signature change in the tracking issue, assuming we can come to a conclusion before very long.

@Dylan-DPC
Copy link
Member

I'd be okay with holding this open while we discuss a possible signature change in the tracking issue, assuming we can come to a conclusion before very long.

@camsteffen you don't need to since the feature is unstable. So changes can be made later before stabilisation

@bors
Copy link
Contributor

bors commented Jul 1, 2022

☔ The latest upstream changes (presumably #98706) made this pull request unmergeable. Please resolve the merge conflicts.

@wesleywiser wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2022
@joshtriplett joshtriplett mentioned this pull request Jul 6, 2022
Closed
8 tasks
@Dylan-DPC
Copy link
Member

@camsteffen any updates on this?

@camsteffen
Copy link
Contributor Author

Honestly my main motivation for this was to weigh &self vs. self. Do folks think this is still worthwhile?

@wesleywiser
Copy link
Member

Honestly my main motivation for this was to weigh &self vs. self. Do folks think this is still worthwhile?

Compiler changes look fine to me but this seems like a question for @rust-lang/libs-api.

@camsteffen
Copy link
Contributor Author

The question has already been resolved in the tracking issue.

@wesleywiser
Copy link
Member

Sorry, I interpreted your question as asking if it was still useful to discuss &self vs self, not if the PR is useful.

If you want to rebase the PR, I'd be willing to review and merge it but if the main goal was just to demonstrate the usage in the context of a larger codebase, then I think that's already been accomplished and it might not be worth resolving all of the merge conflicts just to get it in.

@camsteffen
Copy link
Contributor Author

Yeah I'll just close this.

@camsteffen camsteffen closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@camsteffen @rust-highfive @joshtriplett @Dylan-DPC @bors @wesleywiser @camelid @rustbot