Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and stabilize process_set_process_group #99088

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Document and stabilize process_set_process_group #99088

merged 2 commits into from
Jul 17, 2022

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Jul 9, 2022

Tracking issue: #93857

FCP finished here: #93857 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 9, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 9, 2022
@niklasf
Copy link
Contributor Author

niklasf commented Jul 9, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 9, 2022
@joshtriplett
Expand documentation for process_group
629b0b4 
Explain PGID 0, and provide the acronym PGID.
@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 16, 2022
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 16, 2022

📌 Commit 629b0b4 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2022
@JohnTitor JohnTitor mentioned this pull request Jul 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2022
@bors
Auto merge of rust-lang#99362 - JohnTitor:rollup-4d5zo9d, r=JohnTitor
1cd72b7 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#94927 (Stabilize `let_chains` in Rust 1.64)
 - rust-lang#97915 (Implement `fmt::Write` for `OsString`)
 - rust-lang#99036 (Add `#[test]` to functions in test modules)
 - rust-lang#99088 (Document and stabilize process_set_process_group)
 - rust-lang#99302 (add tracking issue to generic member access APIs)
 - rust-lang#99306 (Stabilize `future_poll_fn`)
 - rust-lang#99354 (Add regression test for rust-lang#95829)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f49d267 into rust-lang:master Jul 17, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 17, 2022
@JohnTitor JohnTitor mentioned this pull request Jul 18, 2022
Closed
4 tasks
@ipetkov ipetkov mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

Assignees

@joshtriplett joshtriplett

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@niklasf @rustbot @rust-highfive @joshtriplett @bors