Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove an unnecessary span_to_snippet #99199

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jul 13, 2022

span_suggestion_hidden does not show the suggested code and the suggestion is used just for rustfix, so span_to_snippet is unnecessary here.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 13, 2022
@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2022
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 13, 2022

📌 Commit f65bf0b has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98574 (Lower let-else in MIR)
 - rust-lang#99011 (`UnsafeCell` blocks niches inside its nested type from being available outside)
 - rust-lang#99030 (diagnostics: error messages when struct literals fail to parse)
 - rust-lang#99155 (Keep unstable target features for asm feature checking)
 - rust-lang#99199 (Refactor: remove an unnecessary `span_to_snippet`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3933b2b into rust-lang:master Jul 13, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 13, 2022
@TaKO8Ki TaKO8Ki deleted the remove-unnecessary-span-to-snippet branch July 18, 2022 05:49
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 18, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98574 (Lower let-else in MIR)
 - rust-lang#99011 (`UnsafeCell` blocks niches inside its nested type from being available outside)
 - rust-lang#99030 (diagnostics: error messages when struct literals fail to parse)
 - rust-lang#99155 (Keep unstable target features for asm feature checking)
 - rust-lang#99199 (Refactor: remove an unnecessary `span_to_snippet`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
JohnTitor pushed a commit to JohnTitor/rust that referenced this pull request Jul 26, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98574 (Lower let-else in MIR)
 - rust-lang#99011 (`UnsafeCell` blocks niches inside its nested type from being available outside)
 - rust-lang#99030 (diagnostics: error messages when struct literals fail to parse)
 - rust-lang#99155 (Keep unstable target features for asm feature checking)
 - rust-lang#99199 (Refactor: remove an unnecessary `span_to_snippet`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants