Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark stabilized intrinsics with rustc_allowed_through_unstable_modules #99288

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

Aaron1011
Copy link
Member

Fixes #99286

PR #95956 accidentally made these intrinsics unstable when
accessed through the unstable path segment 'std::intrinsics'

Fixes rust-lang#99286

PR rust-lang#95956 accidentally made these intrinsics unstable when
accessed through the unstable path segment 'std::intrinsics'
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2022
@Aaron1011
Copy link
Member Author

cc @yaahc @cjgillot

@Aaron1011 Aaron1011 force-pushed the stable-intrinsics branch 2 times, most recently from 0ba18e4 to ef8e322 Compare July 15, 2022 17:35
@SkiFire13
Copy link
Contributor

PR #95956 accidentally made these intrinsics unstable when
accessed through the unstable path segment 'std::intrinsics'

In that PR there was a crater run and the regressions were identified, but never discussed.

#95956 (comment)

@yaahc
Copy link
Member

yaahc commented Jul 15, 2022

Oof, ty for catching that, as @SkiFire13 pointed out I reviewed the crater run and identified all of the APIs that needed that attribute and I did the work to add support for that attribute, but when I came back to the PR to finish the last steps I mistakenly remembered having already added those attributes and didn't carefully re-read my own diff 🤦‍♀️ .

@Aaron1011
Copy link
Member Author

This is affecting several repositories - can we get this merged today, so that it makes it into the next nightly?

@yaahc
Copy link
Member

yaahc commented Jul 15, 2022

Oh, of course, thank you for the reminder. For some reason I was thinking this had to be approved by compiler and not libs, feeling bit scatter brained today >_<

@bors r+

@bors
Copy link
Contributor

bors commented Jul 15, 2022

📌 Commit ef8e322 has been approved by yaahc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022
@Mark-Simulacrum
Copy link
Member

@bors p=5

@bors
Copy link
Contributor

bors commented Jul 15, 2022

⌛ Testing commit ef8e322 with merge 8c1cc82...

@bors
Copy link
Contributor

bors commented Jul 16, 2022

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing 8c1cc82 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2022
@bors bors merged commit 8c1cc82 into rust-lang:master Jul 16, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 16, 2022
@Aaron1011 Aaron1011 deleted the stable-intrinsics branch July 16, 2022 00:19
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c1cc82): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-0.7% -0.7% 1
Improvements 🎉
(secondary)
-3.1% -3.1% 1
All 😿🎉 (primary) -0.7% -0.7% 1

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.8% -2.8% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::intrinsics::copy_nonoverlapping is marked unstable on the latest nightly
9 participants