Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #99533

Closed
wants to merge 13 commits into from

Commits on Jul 15, 2022

  1. Configuration menu
    Copy the full SHA
    c8165c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Configuration menu
    Copy the full SHA
    c39826e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6454a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Configuration menu
    Copy the full SHA
    c44fa6e View commit details
    Browse the repository at this point in the history
  2. tests: fix rustdoc tests

    Logarithmus committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    8530407 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. clippy::perf fixes

    matthiaskrgr committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    611bbcb View commit details
    Browse the repository at this point in the history
  2. Fix the stable version of AsFd for Arc<T> and Box<T>

    These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
    feature that stabilized in 1.63.0.
    cuviper committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    bd0474d View commit details
    Browse the repository at this point in the history
  3. Add map_continue and continue_value combinators to ControlFlow

    Fix type error
    
    Fix continue_value doc comment
    benluelo committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    1993a5f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#99393 - Logarithmus:feature/99255-omit-cons…

    …t-generic-suffixes, r=petrochenkov
    
    feat: omit suffixes in const generics (e.g. `1_i32`)
    
    Closes rust-lang#99255
    matthiaskrgr committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f0abcd4 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#99449 - compiler-errors:assoc-const-missing…

    …-item, r=lcnr
    
    Do not resolve associated const when there is no provided value
    
    Fixes rust-lang#98629, since now we just delay a bug when we're not able to evaluate a const item due to the value not actually being provided by anything. This means compilation proceeds forward to where the "missing item in impl" error is emitted.
    
    ----
    
    The root issue here is that when we're looking for the defining `LeafDef` in `resolve_associated_item`, we end up getting the trait's AssocItem instead of the impl's AssocItem (which does not exist). This resolution "succeeds" even if the trait's item has no default value, and then since this item has no value to evaluate, it turns into a const eval error.
    
    This root issue becomes problematic (as in rust-lang#98629) when this const eval error happens in wfcheck (for example, due to normalizing the param-env of something that references this const). Since this happens sooner than the check that an impl actually provides all of the items that a trait requires (which happens during later typecheck), we end up aborting compilation early with only this un-informative message.
    
    I'm not exactly sure _why_ this bug arises due to rust-lang#96591 -- perhaps valtrees are evaluated more eagerly than in the old system?
    
    r? `@oli-obk` or `@lcnr` since y'all are familiar with const eval and reviewed rust-lang#96591, though feel free to reassign.
    
    This is a regression from stable to beta, so I would be open to considering this for beta backport. It seems correct to me, especially given the improvements in the other UI tests this PR touches, but may have some side-effects that I'm unaware of...?
    matthiaskrgr committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    19c1d52 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#99454 - benluelo:control-flow/continue-comb…

    …inators, r=scottmcm
    
    Add map_continue and continue_value combinators to ControlFlow
    
    As suggested in this comment: rust-lang#75744 (comment)
    
    Related tracking issue: rust-lang#75744
    
    r? `@scottmcm`
    matthiaskrgr committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    714a3fd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#99523 - cuviper:asfd_ptrs-1.64, r=jyn514

    Fix the stable version of `AsFd for Arc<T>` and `Box<T>`
    
    These merged in rust-lang#97437 for 1.64.0, apart from the main `io_safety`
    feature that stabilized in 1.63.0.
    matthiaskrgr committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    37e62fa View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#99528 - matthiaskrgr:2022_07_perf, r=estebank

    couple of clippy::perf fixes
    matthiaskrgr committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    335457f View commit details
    Browse the repository at this point in the history