Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use versionsort for everything that's auto-reordered by name #3764

Merged
merged 8 commits into from
Apr 18, 2020
Merged

Use versionsort for everything that's auto-reordered by name #3764

merged 8 commits into from
Apr 18, 2020

Commits on Apr 10, 2020

  1. Add a version sort implementation and tests

    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f0546fe View commit details
    Browse the repository at this point in the history

  2. reorder: restore fallback comparison by alias 

    The tests were modified in fa75ef4 (part of rust-lang#2535), probably
accidentally as the comments documenting the old expectations were kept.
    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    0b588fa View commit details
    Browse the repository at this point in the history

  3. reorder: use versionsort for use statements

    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    2bb8b71 View commit details
    Browse the repository at this point in the history

  4. reorder: slightly simplify impl Ord for UseTree 

    No functional change.
    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f20f44d View commit details
    Browse the repository at this point in the history

  5. reorder: use versionsort for self/super/crate as name 

    Just for consistency with other use-statement parts.
    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    02f30f3 View commit details
    Browse the repository at this point in the history

  6. reorder: use versionsort for mod and extern crate

    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    e0f1b01 View commit details
    Browse the repository at this point in the history

  7. reorder: use versionsort for item names

    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4556e85 View commit details
    Browse the repository at this point in the history

  8. reorder: add test for compare_opt_ident_as_versions

    @tanriol
    tanriol committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    8c0e580 View commit details
    Browse the repository at this point in the history