Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newlines in where clauses for v2 #5867

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Remove newlines in where clauses for v2 #5867

merged 1 commit into from
Aug 16, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Jul 30, 2023

Fixes #5655.

Closes #5679. This PR is an alternative that feature-gates the fix per the comment in that PR.

@kevinji
Copy link
Contributor Author

kevinji commented Aug 14, 2023

cc @ytmimi who reviewed the original PR

ytmimi
ytmimi approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help here, and your first contribution to rustfmt 🥳!

@ytmimi ytmimi merged commit a57d57b into rust-lang:master Aug 16, 2023
27 checks passed
@ytmimi ytmimi mentioned this pull request Aug 16, 2023
Closed
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Aug 16, 2023
@ytmimi ytmimi mentioned this pull request Aug 16, 2023
Open
@kevinji kevinji deleted the fix-where-clause-newlines branch August 16, 2023 19:42
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty lines in where-clause
3 participants
@kevinji @ytmimi @rustbot