Implement RISC-V Zb intrinsics #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. |
11 tasks
|
Most of these already exist as plain Rust operations or methods on the integer types. We do not need intrinsics for these. I would only keep these which don't have a straightforward mapping to plain Rust code:
|
|
☔ The latest upstream changes (presumably f17c175) made this pull request unmergeable. Please resolve the merge conflicts. |
coastalwhite
force-pushed
the
riscv-zb-ext-intrinsics
branch
from
6f4ce9d
to
b216645
Compare
coastalwhite
force-pushed
the
riscv-zb-ext-intrinsics
branch
from
b216645
to
e73bb65
Compare
|
This is now also done if you are okay with it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR for rust-lang/rust#114544 and a follow-up to #1453.
This PR adds all the instructions for the
zbextension. This PR will get force-pushed after #1453 is merged.