Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't try to reassign a reviewer when a pr title is edited #1755

Merged
merged 1 commit into from
Jan 25, 2024
Merged

don't try to reassign a reviewer when a pr title is edited #1755

merged 1 commit into from
Jan 25, 2024

Commits on Dec 18, 2023

  1. don't re-run command handlers when a pr title is edited 

    doing so leads to weird errors:

> Could not assign reviewer from: jyn514.
> User(s) jyn514 are either the PR author, already assigned, or on vacation, and there are no other candidates.
> Use r? to specify someone else to assign.

this was likely missed when transitioning from highfive to triagebot.

see rust-lang/rust#118993 for an example of a bug this fixes
    @jyn514
    jyn514 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1ac30e8 View commit details
    Browse the repository at this point in the history