Streaming #76
Merged
Streaming #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebfull as requested, you will just need to run tests with --features tokio for it to compile though, please let me know any fixes I can do. |
|
I am super busy but I'm excited to review this patch. I will do so while I'm out of town next week. I apologize for the delay. |
|
seems like examples/streamlisten.rs hasn't listed futures as dependency (for rustc stable and beta at least) EDIT: reference: rust-lang/cargo#1570 |
use the default device instead of en0 (for me the default device is enp9s0 for others maybe eth0 or wlan0 or wlp8s0, so let pcap choose) an alternative might be to let the user sepcify a device on the command line, but this is just an example
Update streamlisten.rs
This was referenced Jul 29, 2017
Closed
|
Awesome! No complaints on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the @Roxxik's referenced in #71.