Added keyboard layout translation for key input in wasm #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
DS - web
C - waiting on maintainer
|
Sorry that you've patched was missed likely due to wasm maintainers being mia in general in winit. We have a more general solution to what you describe in #2662 which will land about now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this problem where when running on WASM, the keyboard input was locked to QWERTY.
The change I made only fix the layout for key that output letters (so A, B, C, ...) and is only made because the new Keyboard API is to be released someday.
Other keys could be added but I don't have the knowledge to automate such things (as I need to open a page, test every key on my keyboard and record the
keyvalue by hand)