Window handle: Return an error when not on main thread on macOS and iOS #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#3270 was merged! |
madsmtm
force-pushed
the
rwh-main-thread-apple
branch
from
6d8fa48
to
6e7df36
Compare
madsmtm
commented
Dec 22, 2023
Comment on lines
+1535
to
+1536
| // SAFETY: The window handle will never be deallocated while the window is alive, | ||
| // and the main thread safety requirements are upheld internally by each platform. |
There was a problem hiding this comment.
I'm intending to change the docs for raw-window-handle to make it clear that this is what's required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3270.
CHANGELOG.mdif knowledge of this change could be valuable to users