Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

[WIP] Update futures-preview to 0.3.0-alpha.16 #26

Merged
merged 2 commits into from
May 12, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented May 8, 2019

Description

await syntax was implemented in rust-lang/rust#60586, and nightly-2019-05-09 has been released with the changes. Also, await! macro will be removed in the future.

Then, futures 0.3.0-alpha.16 was released.

Refs: migration tool

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

With this change, the minimum required version will go up to nightly-2019-05-09.

@taiki-e taiki-e changed the title [WIP] Replace await! macro with await syntax Replace await! macro with await syntax May 9, 2019
@taiki-e taiki-e marked this pull request as ready for review May 9, 2019 02:50
@taiki-e taiki-e force-pushed the await branch 2 times, most recently from 23b6040 to 970cc75 Compare May 9, 2019 03:04
@taiki-e
Copy link
Contributor Author

taiki-e commented May 11, 2019

futures 0.3.0-alpha.16 was released, so I added a commit and updated this PR.

@taiki-e
Copy link
Contributor Author

taiki-e commented May 11, 2019

This PR is blocked on withoutboats/romio#87 and withoutboats/juliex#18.

@taiki-e taiki-e changed the title Replace await! macro with await syntax [WIP] Update futures-preview to 0.3.0-alpha.16 May 11, 2019
Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 668194f into rustasync:master May 12, 2019
@yoshuawuyts
Copy link
Collaborator

Oh oops, meant to hit merge on the Romio PR. Going to merge those first, and loop around to fixing this. Running the release train today!

@taiki-e taiki-e deleted the await branch May 12, 2019 16:04
@yoshuawuyts
Copy link
Collaborator

Yay, fixed it and ran a full deploy for all crates! Thanks so much @taiki-e!! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants