Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic linking experiments are stumbled by unconditional "--export-table" #251

Closed
pepyakin opened this issue Jan 22, 2019 · 4 comments
Closed

Comments

@pepyakin
Copy link
Member

I've discovered flags like --pic/--shared in the latest LLD (seems to be not yet available in the LLD shipped with rust). But when I try to use them I'm getting this LLD error:

lld: error: -shared/-pie is incompatible with --export-table

I tried to pass --import-table to override the rustc passed --export-table, however, LLD doesn't support that, and fails with

lld: error: --import-table and --export-table may not be used together

Do you have any idea how to proceed here?

@alexcrichton
Copy link
Contributor

There's a bit of discussion on the original PR, and it seems like if LLD doesn't support both flags then we should remove the argument from rustc and require users to pass in an explicit value.

cc @overdrivenpotato

@pepyakin
Copy link
Member Author

Oh, the problem might be deeper, since overriding of stack size doesn't seem to work either.

@alexcrichton
Copy link
Contributor

I believe the stack size aspect was addressed by rust-lang/rust#57337

Centril added a commit to Centril/rust that referenced this issue Jan 24, 2019
…alexcrichton

Don't export table by default in wasm

Revert of rust-lang#53237
As per discussion here rustwasm/team#251
Centril added a commit to Centril/rust that referenced this issue Jan 24, 2019
…alexcrichton

Don't export table by default in wasm

Revert of rust-lang#53237
As per discussion here rustwasm/team#251
@alexcrichton
Copy link
Contributor

Should have been fixed in rust-lang/rust#57861, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants