Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lock wasm-pack packages to nightly #217

Closed
itsybitesyspider opened this issue Jul 17, 2018 · 3 comments
Closed

Don't lock wasm-pack packages to nightly #217

itsybitesyspider opened this issue Jul 17, 2018 · 3 comments
Labels
question Further information is requested

Comments

@itsybitesyspider
Copy link
Contributor

Currently, wasm-pack seems to call cargo build with +nightly. This may not be the user's intention, especially in "no-install" mode.

If I'm not mistaken we can set the toolchain using rustup override set nightly immediately after installing it. Then if we installed the toolchain we'll automatically use it in every subsequent command, and if we didn't then whatever goes wrong will be the user's responsibility. :)

If no one objects or gets to it before me I'll submit a pull request.

@itsybitesyspider itsybitesyspider changed the title Don't lock wasm-pack to nightly Don't lock wasm-pack packages to nightly Jul 17, 2018
@ashleygwilliams ashleygwilliams added the question Further information is requested label Jul 19, 2018
@ashleygwilliams
Copy link
Member

hey @clanehin ! at the moment, wasm-bindgen only works on nightly, so in order to build we'd need nightly still. once the 2018 edition lands, we should be able to move wasm-bindgen to stable, and then i would absolutely be interested in this :)

@itsybitesyspider
Copy link
Contributor Author

wasm-bindgen only works on nightly

Yep, but it doesn't have to be +nightly specifically. It will work fine with reasonably recent nightly releases like "nightly-2018-06-24".

@ashleygwilliams
Copy link
Member

we;re going to address this #289, closing this in favor of the most recent one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants