Don't force usage of the nightly toolchain

[alexcrichton]

💡 Feature description

Currently wasm-pack will automatically switch to (and download if necessary) the nightly toolchain, but the upcoming 1.30.0 release will support wasm-bindgen and wasm-pack on stable. It'd be great if, while 1.30.0 is in beta, we could also test out beta!

One idea could be to perhaps look at rustc's current version and automatically switch to nightly if it's less than 1.30.0 and otherwise use it as-is if it's 1.30.0+

[ashleygwilliams]

One idea could be to perhaps look at rustc's current version and automatically switch to nightly if it's less than 1.30.0 and otherwise use it as-is if it's 1.30.0+

sounds good to me! would we want ways to manually override as well? --toolchain=nightly or --toolchain=beta

we ended up forcing nightly because people with strange setups were sometimes running into issues where another toolchain ended up getting used. i don't feel strongly about it and i think it's a good idea to make it more flexible as the edition approaches!

[alexcrichton]

I think long term we'd probably want to avoid toolchain management entirely in the sense of just inheriting what the user has already configured. In the short-term though rustup run nightly wasm-pack ... is pretty unergonomic for users whose default compiler is stable and want to run wasm-pack

[CRogers]

I've been very confused for the past hour or so because wasm-init is not using the toolchain I've listed in my rust-toolchain. Instead it ended up using and older nightly I have installed which has this bug: rust-lang/rust#53813

To fix, I just had to rustup update nightly, but would be great for wasm-pack to use the preconfigured rust version (I like consistent builds and depending on a moving target like nightly scares me!).

[ashleygwilliams]

closing in favor of #351

[fiatjaf]

For future reference of absolute beginners: I got here because I was trying to compile some stuff that required the nightly toolchain but wasm-pack wasn't using it. I ended up installing and setting the nightly toolchain as the default and running wasm-pack again and it worked.

rustup install nightly
rustup default nightly